Add aux_factory HybridLogPressureFactory for atmosphere_hybrid_sigma_ln_pressure_coordinate - #7255
Draft
k-a-webb wants to merge 9 commits into
Draft
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the addition of a new parametric vertical coordinate in the CF conventions (see PR WCRP-CMIP/Essential-Model-Documentation#396, docs https://cfconventions.org/cf-conventions/cf-conventions.html#_atmosphere_hybrid_sigma_log_pressure_coordinate) for
atmosphere_hybrid_sigma_ln_pressure_coordinate, a newiris.aux_factoryis required to support models with these coordinates.Please note: This is my first PR to iris, any assistance or helpful feedback is appreciated. I work with the ECCC CCCma on the development of the CanESM models, where CanESM6-0-MR for CMIP7 is one of the datasets that uses
atmosphere_hybrid_sigma_log_pressure_coordinate.The new class, and related modifications, are based on the implementation of the existing
HybridPressureFactory.Checklist
Important
The Iris core developers are here to help! If anything below is unclear, just post a comment asking for help 😊
(further reading)
Tip
Things you can trigger on this PR:
9999for this PR's number - to re-trigger the CLA check:https://cla-assistant.io/check/SciTools/iris?pullRequest=9999