[CLI] Convert some options as argument - #12278
Draft
BluNfa wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8556
Directly pass device id instead of
deviceoption indevice removecommand.Directly pass the org-id instead of
organization-idoption inorganization statscommand.Directly pass the org-id instead of
organization-idoption inorganization statuscommand.Directly pass import path instead of
inputoption indevice import-recovery-devicecommand.The other options from #8556 seems already converted to arguments.
PR is in draft because, for the
deviceoption indevice removecommand, the help output is different from the other ones:DEVICE is between [ ], and not between < > like the arguments in other commands, and I fail to understand why. Export recovery device help command for reference :