Rework libparsec_platform_pki 9: Rework X509Certificate on server - #12585
Closed
touilleMan wants to merge 1 commit into
Closed
Conversation
touilleMan
force-pushed
the
rework-platform-pki-9-fix-server
branch
from
April 10, 2026 07:47
dff4c53 to
b36df79
Compare
touilleMan
force-pushed
the
rework-platform-pki-8-fix-libparsec_platform_device_loader
branch
from
April 10, 2026 07:55
d1d47c7 to
7a3f1b0
Compare
touilleMan
force-pushed
the
rework-platform-pki-9-fix-server
branch
from
April 10, 2026 07:55
b36df79 to
0828732
Compare
touilleMan
force-pushed
the
rework-platform-pki-8-fix-libparsec_platform_device_loader
branch
from
April 10, 2026 08:08
7a3f1b0 to
cb8a03f
Compare
touilleMan
force-pushed
the
rework-platform-pki-9-fix-server
branch
from
April 10, 2026 08:08
0828732 to
aca9d76
Compare
touilleMan
force-pushed
the
rework-platform-pki-8-fix-libparsec_platform_device_loader
branch
from
April 15, 2026 14:08
cb8a03f to
dd071a1
Compare
touilleMan
force-pushed
the
rework-platform-pki-9-fix-server
branch
from
April 15, 2026 14:08
aca9d76 to
7c04624
Compare
touilleMan
force-pushed
the
rework-platform-pki-8-fix-libparsec_platform_device_loader
branch
from
April 16, 2026 08:54
dd071a1 to
1ef4d2b
Compare
touilleMan
force-pushed
the
rework-platform-pki-9-fix-server
branch
from
April 16, 2026 08:54
7c04624 to
e955568
Compare
AureliaDolo
approved these changes
Apr 16, 2026
touilleMan
force-pushed
the
rework-platform-pki-9-fix-server
branch
from
April 18, 2026 02:29
e955568 to
3f3deee
Compare
touilleMan
force-pushed
the
rework-platform-pki-8-fix-libparsec_platform_device_loader
branch
from
April 18, 2026 02:29
1ef4d2b to
4c5bd90
Compare
- Rework `X509Certificate` to do eager validation and have properties for issuer/subject/sha256_fingerprint/der - Remove no longer needed Python type `X509Certificate2` (it only goal was to correct the shortcoming of `X509Certificate`) - Rename `TrustAnchor` -> `X509TrustAnchor` - Remove unused `PkiUntrusted` & `PkiInvalidSignature` exceptions - Remove `PkiInvalidCertificateDER` exception: use `ValueError` instead for consistency&simplicity - Rename `X509Certificate`/`X509TrustAnchor` methods `try_from_pem`/`from_pem`/`from_der` -> `load_pem`/`load_der` (for consistency with `Sequester*KeyDer` types that also load PEM/DER formats)
touilleMan
force-pushed
the
rework-platform-pki-8-fix-libparsec_platform_device_loader
branch
from
April 21, 2026 10:52
4c5bd90 to
a39f0c3
Compare
touilleMan
force-pushed
the
rework-platform-pki-9-fix-server
branch
from
April 21, 2026 10:52
3f3deee to
77c662f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X509Certificateto do eager validation and have properties for issuer/subject/sha256_fingerprint/derX509Certificate2(it only goal was to correct the shortcoming ofX509Certificate)TrustAnchor->X509TrustAnchorPkiUntrusted&PkiInvalidSignatureexceptionsPkiInvalidCertificateDERexception: useValueErrorinstead for consistency&simplicityX509Certificate/X509TrustAnchormethodstry_from_pem/from_pem/from_der->load_pem/load_der(for consistency withSequester*KeyDertypes that also load PEM/DER formats)