Fix mixed-line-ending pre-commit rule - #12950
Open
touilleMan wants to merge 1 commit into
Open
Conversation
FirelightFlagboy
requested changes
Jun 16, 2026
Contributor
There was a problem hiding this comment.
I don't mind adding that extra config, but It's already done during CI Q&A during the step "Patch pre-commit for line-ending".
If it wasn't already included in the base configuration it's likely because there is a reason that would impact Windows devs.
Anyway, the Windows devs are expected to configure git with autocrlf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this option it seems this check doesn't reject
\r\n(e.g. see fabc17c onreleases/3.9that hasn't been rejected)