Skip to content

lunatranslator: Update to version 12.1.2.8, fix autoupdate - #19057

Merged
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
Vinfall:lunatranslator
Oct 16, 2026
Merged

z-Fng merged 1 commit into
ScoopInstaller:masterfrom
Vinfall:lunatranslator

Conversation

@Vinfall

@Vinfall Vinfall commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

LunaTranslator removed x86_win7 zip in v12 update, breaking autoupdate. This PR switched to x86_winxp zip instead.

PS: I'm sure if scoop can be used on Windows XP. If not, it might make more sense to drop 32bit architecture in the manifest.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: ScoopInstaller/Extras/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 02c839b0-f99a-4bbb-9994-78d522584c91
📥 Commits

Reviewing files that changed from the base of the PR and between ca82434 and a9498ad.

📒 Files selected for processing: 1
  • bucket/lunatranslator.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The Scoop manifest updates LunaTranslator from version 10.17.1.11 to 12.1.2.8. It changes the 64-bit and 32-bit download URLs and hashes. The 32-bit archive, extraction directory, and auto-update URL now use the winxp package instead of the win7 package.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~7 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to a9498

The updated release assets and auto-update paths are consistent with the manifest, with no concrete merge risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly identifies the manifest and the two main changes: the version update and autoupdate fix.
Description check Passed The description explains the manifest change, the autoupdate issue, and the selected architecture change. It includes both required checklist items. It does not include a related issue reference, but …
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the manifest change, the autoupdate issue, and the selected architecture change. It includes both required checklist items. It does not include a related issue reference, but the main required information is present.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@z-Fng z-Fng changed the title lunatranslator: Update to 12.1.2.8, Fix autoupdate lunatranslator: Update to version 12.1.2.8, fix autoupdate Oct 16, 2026
@z-Fng

z-Fng commented Oct 16, 2026

Copy link
Copy Markdown
Member

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

lunatranslator

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng
z-Fng merged commit d03a387 into ScoopInstaller:master Oct 16, 2026
6 checks passed
@z-Fng

z-Fng commented Oct 16, 2026

Copy link
Copy Markdown
Member

PS: I'm sure if scoop can be used on Windows XP. If not, it might make more sense to drop 32bit architecture in the manifest.

The x86_winxp build is forward-compatible and also runs on Windows 7 and Windows 10, so keeping it still makes sense.

@Vinfall
Vinfall deleted the lunatranslator branch October 16, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants