Skip to content

Commit 6a30ac6

Browse files
fix: enable full n8n node/credential ESLint rules and fix violations
- Add credentials and nodes configs to eslint.n8n.config.mjs (113 additional rules) - Fix resource option plural: "Credits" → "Credit" - Fix status filter options alphabetical ordering - Disable conflicting doc-url rules from older plugin
1 parent c19b996 commit 6a30ac6

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

‎eslint.n8n.config.mjs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ export default [
1515
},
1616
rules: {
1717
...n8nPlugin.configs["community"].rules,
18+
...n8nPlugin.configs["credentials"].rules,
19+
...n8nPlugin.configs["nodes"].rules,
20+
// The older plugin's doc-url rules conflict with @n8n/eslint-plugin-community-nodes
21+
// which correctly allows full HTTP URLs for documentationUrl
22+
"n8n-nodes-base/cred-class-field-documentation-url-miscased": "off",
23+
"n8n-nodes-base/cred-class-field-documentation-url-not-http-url": "off",
1824
},
1925
},
2026
];

‎nodes/ScraperNodeJobs/ScraperNodeJobs.node.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export class ScraperNodeJobs implements INodeType {
3535
noDataExpression: true,
3636
options: [
3737
{ name: "Job", value: "job" },
38-
{ name: "Credits", value: "credits" },
38+
{ name: 'Credit', value: "credits" },
3939
],
4040
default: "job",
4141
},
@@ -102,10 +102,10 @@ export class ScraperNodeJobs implements INodeType {
102102
type: "options",
103103
options: [
104104
{ name: "All", value: "" },
105-
{ name: "Pending", value: "pending" },
106-
{ name: "Processing", value: "processing" },
107105
{ name: "Completed", value: "completed" },
108106
{ name: "Failed", value: "failed" },
107+
{ name: "Pending", value: "pending" },
108+
{ name: "Processing", value: "processing" },
109109
],
110110
default: "",
111111
displayOptions: {

0 commit comments

Comments
 (0)