Repository navigation
fix: save downloaded ads with unresolved shipping options - #1346
Merged
1cu merged 2 commits intoOct 15, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
=======================================
Coverage 92.15% 92.16%
=======================================
Files 50 50
Lines 7804 7808 +4
Branches 1360 1361 +1
=======================================
+ Hits 7192 7196 +4
Misses 401 401
Partials 211 211
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
1cu
marked this pull request as ready for review
October 15, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Description
download --ads=allcurrently skips direct-purchase-eligible ads when their displayed shipping price cannot be mapped to a predefined shipping option. Calculating the initial content hash raisessell_directly requires at least one predefined shipping_options entry.Save those ads with explicit
sell_directly: falseandshipping_options: [], retain the extracted shipping costs, and warn the user to review shipping options before re-enabling direct purchase. Do not guess a carrier or inherit unrelated default options. Normal model validation remains unchanged.Related context: #1256 addressed a different shipping extraction failure; this case has
shipping_type: SHIPPINGbut no usable option. Reproduced with offline extraction tests against current main / latest release source.📋 Changes Summary
⚙️ Type of Change
✅ Checklist
pdm run test: 1,947 passed, 4 skipped; Xvfb, one worker).pdm run format).pdm run lint).Tests never contact Kleinanzeigen. An earlier concurrent local run had two Node subprocess timeouts; the isolated affected suite (80 tests) and the subsequent complete run both passed.
Manual runtime validation after deployment: both previously failing ads downloaded successfully using the persisted account session (4 and 2 images). Both exported with the documented warning,
sell_directly: false, and empty shipping options; no download errors were logged. Account data and ad content are intentionally omitted.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.