Repository navigation
Commit 481d865
Sefina-DS
fix: correct release.sh side effects from v0.1.23 (LEARNINGS #35 pitfall)
Two real problems, both from the manual news entry having been inserted
at the TOP of the news dict in the release-prep step instead of appended
at the end (deviating from this file's established chronological/
insertion order):
1. README.md: release.sh prepended its own short "### 0.1.23" section
without checking one already existed - documented pitfall from
LEARNINGS #35. Removed the duplicate, kept the detailed entry.
2. io-package.json (more serious): release.sh's "keep max 7 news
entries" pruning does `del news[keys[0]]` while there are more than
7 - i.e. it removes whichever entry is FIRST by dict insertion order.
Because the manually-added "0.1.23" entry sat at position 0 (not the
end, where 0.1.16-0.1.22 were originally ordered oldest-to-newest),
the pruning step deleted the 0.1.23 entry itself instead of the
actual oldest one (0.1.16) - result: common.version was 0.1.23 but
the news block had NO matching entry. Re-added 0.1.23 correctly at
the end, removed 0.1.16 to keep the max-7 convention intact.
Note: the v0.1.23 tag was already pushed and GitHub Actions had already
built/published to npm from the buggy commit before this was caught -
that specific published release will show no "what's new" text in the
ioBroker Admin UI. Not retagging/force-pushing to fix a live tag without
separate sign-off; this commit only corrects `main` going forward.1 parent 5f408ff commit 481d865
2 files changed
Lines changed: 13 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | 41 | | |
45 | 42 | | |
46 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | 8 | | |
22 | 9 | | |
23 | 10 | | |
| |||
95 | 82 | | |
96 | 83 | | |
97 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| |||
0 commit comments