bug Multiply items with mcmmo and dank pack

[brasilcraft54]

it is possible to place blocks like this and multiply them, for example I place Ancient Debris in there and use the mcmmo skill to multiply it, because the dank pack detects it as if it was placed by the world and not by a player.

video: https://youtu.be/f91IhSm60B8

Purpur git-Purpur-"08dd6c7" (MC: 1.17.1)
Slimefun DEV - 999 (git e02eedd9)
Metrics-Module #28
Java 16

Installed Addons: (15)
Networks vDEV - 31 (git 773a911c)
DyedBackpacks vDEV - 17 (git 8b329e96)
ExtraTools vDEV - 33 (git 46d26e49)
EcoPower vDEV - 5 (git 5c1ecd68)
HotbarPets vDEV - 38 (git fa6c871d)
ExoticGarden vDEV - 78 (git 7f9a5f63)
DankTech2 vDEV - 4 (git 803760f)
Liquid vDEV - 14 (git 0f5346bf)
CMILib v1.0.3.11
LiteXpansion vDEV - 174 (git e36d509d)
IllegalStack v2.4.2
MobCapturer vDEV - 17 (git c21b00a5)
FlowerPower vDEV - 13 (git 06ad45dc)
SimpleStorage vDEV - 10 (git ea5e5637)
FluffyMachines vDEV - 106 (git 38aa2740)

[brasilcraft54]

a possible fix for this would be that blocks that are placed by the dank pack tier 9, are counted as the person placed and not generated by the world that block.

[brasilcraft54]

I have performed other tests here and it happens with all tier.

[Apeiros-46B]

a possible fix for this would be that blocks that are placed by the dank pack tier 9, are counted as the person placed and not generated by the world that block.

@Sefiraat maybe call a BlockPlaceEvent and set the player to the player who is using the dank pack (Doesn't look like you're calling one currently)? It seems like mcmmo listens to BlockPlaceEvents and acts accordingly (see image)

[char3210]

or you can look at how slimefun handles it with block placers (might also call the event)

[Sefiraat]

I already set the place store when placing blocks which means, without testing yet, its likely a load order issue with mcMMO. Spigot can’t 100% get the load order correctly. Easy fix would be to change my mcMMO hook to the first tick rather than onEnable. I’ll try this out when I have time to triage tomorrow

[brasilcraft54]

I already set the place store when placing blocks which means, without testing yet, its likely a load order issue with mcMMO. Spigot can’t 100% get the load order correctly. Easy fix would be to change my mcMMO hook to the first tick rather than onEnable. I’ll try this out when I have time to triage tomorrow

is like worldedit when I put a block it seems that it was the world that generated that block and not a player, the solution would be that it counted as if a person put the block, people can bug mines infinitely, but ultimately I will wait for this update thanks for your attention.

[brasilcraft54]

I already set the place store when placing blocks which means, without testing yet, its likely a load order issue with mcMMO. Spigot can’t 100% get the load order correctly. Easy fix would be to change my mcMMO hook to the first tick rather than onEnable. I’ll try this out when I have time to triage tomorrow

any news?

[brasilcraft54]

one more bug I found now multiplies multiple items.

-> https://www.youtube.com/watch?v=rYRYoOI5w6c

[SrMonsterYT]

has this bug been fixed or does it still work?

[SrMonsterYT]

?

[SrMonsterYT]

has this addon been abandoned?

[Sefiraat]

No it has not, if you read up above the issue is most likely due to the plugin load order and the issue cannot be reproduced by myself locally.

I tested applying this on the first tick as mentioned above but encountered issues. It will be fixed when time permits :)

[SrMonsterYT]

ok i am sad to have to remove this addon from my server since i posted the addon i had to remove it, but i would be very happy to add it again this addon is very good and important to our community for fun

[SrMonsterYT]

This addon is so cool, and a shame that it was abandoned like this.

[Sefiraat]

@SrMonsterYT please think before you type. You have been warned before. This addon is not abandoned and I do not appreciate the comment. Thank you.