Repository navigation
Commit 658aebc
[build] Update Selenium Grid 4.49.0 (#3240)
* [build] Update Selenium Grid 4.49.0
* [test] Make the exporter session fixture immune to the release-day sed
The three session tests in the exporter have been failing on trunk since
5589297, and not because of anything in the exporter:
--- FAIL: TestCollectFullSnapshot
selenium_grid_session_start_seconds{s1} missing
--- FAIL: TestSessionLifecycle
start_seconds missing while session active
--- FAIL: TestSessionDurationFallback
fallback duration = 0, want > 0
The fixture's startTime literal was corrupt, so parseGridTime returned 0 and
every metric derived from it disappeared.
It was corrupted by update_tag_in_docs_and_files.sh. That script rewrites the
whole tree with unescaped sed substitutions whose patterns are version strings,
and KEDA_TAG_PREV_VERSION and KEDA_TAG_VERSION are both 2.20.1 (Makefile:33,35).
So it runs what looks like a no-op:
sed -i "s/2.20.1/2.20.1/g"
In a regex `.` is any character, so that pattern matches a run of digits and
separators inside a formatted timestamp and replaces it with the literal version
string. The substitution is destructive even though the two sides are identical.
This is the second time. #3202 repaired the same literal after the 4.47.0
release; the 4.48.0 release broke it straight back. Repairing the literal again
would just queue up a third.
So the fixture no longer contains a timestamp-shaped literal at all: the start
time is built with time.Date and rendered through gridDateFormat, the same
constant the parser uses, and the expected unix value is derived from it rather
than hardcoded so the two cannot drift. A value that only exists at runtime
cannot be corrupted by a sed over the source. The explanatory comment describes
the vulnerable strings rather than quoting them, because quoting them made the
comment itself get rewritten.
Verified by replaying the script's substitutions over the file with the real
previous tag: the file comes back byte-identical, and `go test -race` passes at
95.8% coverage.
The underlying hazard is not fixed here and still applies tree-wide: the ffmpeg,
LATEST_TAG and LATEST_DATE substitutions are unescaped too, and the KEDA and
ffmpeg pairs are currently identical so both are pure no-ops that can only do
damage. Guarding each substitution on PREV != VERSION and escaping the patterns
belongs in its own change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013CTYeQSAs9vEpdGevEcVQE
---------
Co-authored-by: Selenium CI Bot <selenium-ci@users.noreply.github.com>
Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent d737780 commit 658aebc
13 files changed
Lines changed: 65 additions & 32 deletions
File tree
- .github/workflows
- .keda-external-scaler
- .monitoring/exporter
- tests/build-backward-compatible
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
| 33 | + | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
55 | 76 | | |
56 | | - | |
57 | 77 | | |
58 | 78 | | |
59 | 79 | | |
60 | 80 | | |
61 | | - | |
| 81 | + | |
62 | 82 | | |
63 | 83 | | |
64 | 84 | | |
65 | 85 | | |
66 | 86 | | |
67 | 87 | | |
68 | | - | |
69 | | - | |
70 | 88 | | |
71 | 89 | | |
72 | 90 | | |
| |||
273 | 291 | | |
274 | 292 | | |
275 | 293 | | |
276 | | - | |
| 294 | + | |
277 | 295 | | |
278 | 296 | | |
279 | 297 | | |
| |||
344 | 362 | | |
345 | 363 | | |
346 | 364 | | |
347 | | - | |
| 365 | + | |
348 | 366 | | |
349 | 367 | | |
350 | 368 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
| 29 | + | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
7 | 7 | | |
8 | | - | |
9 | | - | |
| 8 | + | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
| 191 | + | |
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
| |||
377 | 377 | | |
378 | 378 | | |
379 | 379 | | |
380 | | - | |
| 380 | + | |
381 | 381 | | |
382 | 382 | | |
383 | 383 | | |
| |||
0 commit comments