Skip to content

fix(TextArea): correct value type in onChange/onInput callback data #4542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Khushighosh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(TextArea): correct value type in onChange/onInput callback data #4542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/addons/TextArea/TextArea.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ export interface StrictTextAreaProps {
* @param {SyntheticEvent} event - The React SyntheticEvent object
* @param {object} data - All props and the event value.
*/
onChange?: (event: React.ChangeEvent<HTMLTextAreaElement>, data: TextAreaProps) => void
onChange?: (event: React.ChangeEvent<HTMLTextAreaElement>, data: TextAreaOnChangeData) => void

/**
* Called on input.
*
* @param {SyntheticEvent} event - The React SyntheticEvent object
* @param {object} data - All props and the event value.
*/
onInput?: (event: React.FormEvent<HTMLTextAreaElement>, data: TextAreaProps) => void
onInput?: (event: React.FormEvent<HTMLTextAreaElement>, data: TextAreaOnChangeData) => void

/** Indicates row count for a TextArea. */
rows?: number | string
Expand All @@ -32,6 +32,11 @@ export interface StrictTextAreaProps {
value?: number | string
}

export interface TextAreaOnChangeData extends TextAreaProps {
/** The value of the textarea, always a string when returned via callback. */
value: string
}

declare const TextArea: ForwardRefComponent<TextAreaProps, HTMLTextAreaElement>

export default TextArea