Repository navigation
Conversation
…rs off [skip-sweep]
|
Thanks for the contribution!
中文感谢你的贡献!
|
| - agentic-coding | ||
| description: | ||
| - "Re-run Kimi-K3.1-Pro vLLM AgentX on B300 with the tool and reasoning parsers off on synthetic-acceptance throughput servers (#4840); evals keep them." | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/4796 |
There was a problem hiding this comment.
🔴 The changelog check will fail this PR, and the re-run results would be credited to the old PR. The new block's pr-link at line 12109 points to pull/4796. That is the merged PR that first added this config at line 12036, not this PR. validate_added_pr_link accepts only the PR's own URL or an XXX placeholder for a new entry. Fix: set the pr-link to this PR's own URL, or to an XXX placeholder until the URL is known. Keep the mention of #4796 in the description if wanted.
Why this was flagged
The diff appends a new entry whose pr-link is #4796 (perf-changelog.yaml:12109). The same URL already belongs to the original entry for kimik3.1-fp4-b300-vllm-agentic-dspark at perf-changelog.yaml:12036, so this PR is a different, later one. In inferencex-e2e/infx/workflows/validate_perf_changelog.py:112-116, every added entry on a PR run must use https://github.com/SemiAnalysisAI/InferenceX/pull/{pr_number} or a value from PR_LINK_PLACEHOLDERS. Anything else raises ChangelogValidationError with "new PR entry must use ... or an XXX placeholder". The changelog validation for this PR therefore fails. If the entry got through some other way, the re-collected results and metadata would point at #4796, and recover_failed_ingest.py compares pr-link against the expected link, so the new sweep would be mixed up with the superseded one. On the base branch no such mismatched entry exists.
Verification: The trigger is that the PR is merged through the supported path, merge_with_reuse (CONTRIBUTING.md:174). The new entry carries an older PR's link, pull/4796 (perf-changelog.yaml:12109). merge_with_reuse._merge_pr_inner always calls canonicalize_changelog(pr, repo) (merge_with_reuse.py:688), and compare_entries raises. The run-sweep PR check does not reject this.
| - "Aggregated low-latency points: one TP16 EP1 worker with the NVIDIA megakernel (--enable-nvidia-megakernel), max-running-requests equal to the concurrency (c1, c2, c4)." | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/4811 | ||
|
|
||
| - config-keys: |
There was a problem hiding this comment.
🔴 The PR's re-run of this config never starts, even with the non-canary-full-sweep-enabled label set. The only commit, 33bcb8b, carries [skip-sweep] in its message. run-sweep.yml:87 reads that marker from the head commit and skips the PR benchmark sweep on every event. So no run exists for the required /use <run_id>, and the stale #4796 results stay in place. Fix: push the changelog entry, or a follow-up head commit, without [skip-sweep] so the labelled sweep actually runs. Amending the commit with the same message keeps the sweep suppressed.
Why this was flagged
The PR's head commit is 33bcb8b, "chore(changelog): re-run Kimi-K3.1-Pro vLLM B300 with synthetic parsers off [skip-sweep]". In .github/workflows/run-sweep.yml:86-91, git log -1 --format=%B "$HEAD_SHA" | grep -Fq '[skip-sweep]' sets skip-pr-sweep=true. The sweep job at run-sweep.yml:178 requires needs.check-changelog.outputs.skip-pr-sweep != 'true' before it checks the full-sweep labels at :180-182. That check runs on labeled events too, so the non-canary-full-sweep-enabled label does not start a sweep while this commit is the head. .github/workflows/README.md:268 says [skip-sweep] skips PR benchmark setup only. The entry at perf-changelog.yaml:12103-12109 exists to replace the #4796 results, and per CONTRIBUTING it needs an accepted /use <run_id> before merge. This PR produces no run to accept, so the parsers-off re-run described in the PR body never happens unless someone pushes a new head commit without the marker. Neither the label nor the changelog check prevents this.
Verification: The PR head stays at 33bcb8b, the only commit, whose subject contains the [skip-sweep] marker. .github/workflows/run-sweep.yml:84-91 sets skip-pr-sweep=true, and the setup job requires needs.check-changelog.outputs.skip-pr-sweep != 'true' (run-sweep.yml:~176), including on labeled events. The re-run never starts on this PR.
|
View unofficial run (performance): https://inferencex.semianalysis.com/inference?unofficialRun=42103738354 View unofficial run (accuracy): https://inferencex.semianalysis.com/evaluation?unofficialRun=42103738354 |
Re-runs
kimik3.1-fp4-b300-vllm-agentic-dspark(#4796) now that #4840 removes the Kimi tool and reasoning parsers from vLLM throughput servers that use synthetic acceptance.#4796's sweep ran with the parsers on, which caused two problems:
This sweep replaces those results.