Repository navigation
[K3.1-Pro] Re-run vLLM on B300 with synthetic parsers off #4841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The PR's re-run of this config never starts, even with the non-canary-full-sweep-enabled label set. The only commit, 33bcb8b, carries
[skip-sweep]in its message. run-sweep.yml:87 reads that marker from the head commit and skips the PR benchmark sweep on every event. So no run exists for the required/use <run_id>, and the stale #4796 results stay in place. Fix: push the changelog entry, or a follow-up head commit, without[skip-sweep]so the labelled sweep actually runs. Amending the commit with the same message keeps the sweep suppressed.Why this was flagged
The PR's head commit is 33bcb8b, "chore(changelog): re-run Kimi-K3.1-Pro vLLM B300 with synthetic parsers off [skip-sweep]". In .github/workflows/run-sweep.yml:86-91,
git log -1 --format=%B "$HEAD_SHA" | grep -Fq '[skip-sweep]'sets skip-pr-sweep=true. The sweep job at run-sweep.yml:178 requiresneeds.check-changelog.outputs.skip-pr-sweep != 'true'before it checks the full-sweep labels at :180-182. That check runs on labeled events too, so the non-canary-full-sweep-enabled label does not start a sweep while this commit is the head. .github/workflows/README.md:268 says[skip-sweep]skips PR benchmark setup only. The entry at perf-changelog.yaml:12103-12109 exists to replace the #4796 results, and per CONTRIBUTING it needs an accepted/use <run_id>before merge. This PR produces no run to accept, so the parsers-off re-run described in the PR body never happens unless someone pushes a new head commit without the marker. Neither the label nor the changelog check prevents this.Verification: The PR head stays at 33bcb8b, the only commit, whose subject contains the
[skip-sweep]marker..github/workflows/run-sweep.yml:84-91setsskip-pr-sweep=true, and thesetupjob requiresneeds.check-changelog.outputs.skip-pr-sweep != 'true'(run-sweep.yml:~176), including onlabeledevents. The re-run never starts on this PR.