Repository navigation
[K3.1-Pro] Re-sweep vLLM on GB200 with the updated DSpark draft #4864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12
−0
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2b6efcb
feat(kimik3.1): re-sweep GB200 vLLM with the updated DSpark draft [sk…
cquil11 a006870
chore(changelog): link the GB200 vLLM re-sweep entry to #4864
cquil11 b961604
chore(changelog): restore historical placeholder links; link only the…
cquil11 2436aac
Merge remote-tracking branch 'origin/main' into pr-4864-reuse-8820
cquil11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 (optional) The changelog says this sweep uses draft
Inferact/Kimi-K3.1-Pro-DSpark-preview @ 6a2ef20a, but no recipe pins that revision. Both rows load whatever the Hub default branch serves. The vLLMspeculative-configJSON in agg-tp8pp2-variants.yaml:89-137 and disagg-variants.yaml:79,107 has norevisionkey. So the recorded points are tied to an unpinned draft, and nothing in either config key actually changes for this re-sweep. Fix: add"revision":"<full 6a2ef20a sha>"to every DSparkspeculative-configin both GB200 recipes. This matches thespeculative-draft-model-revisionpin in the sglang K3.1 recipes.Why this was flagged
Both listed keys start vLLM with speculative-config
{"model":"Inferact/Kimi-K3.1-Pro-DSpark-preview",...}and no revision (agg-tp8pp2-variants.yaml:89-137, disagg-variants.yaml:79,107). The draft that actually loads is whatever the nodes' HF cache or the Hub default branch gives at run time. Per the PR description, that already changed once without any config change. If Inferact pushes again, or a node keeps a stale cache, the results under this changelog entry and the 3.41/3.19 golden-curve forcing describe a different draft than the one that ran. The mismatch is silent. The base branch has the same unpinned load, but this entry is the first to claim a specific revision 6a2ef20a. The sglang K3.1 recipes do pin their draft withspeculative-draft-model-revision(e.g. sglang/gb300-fp4/agentx/disagg-tp16-variants.yaml:110), so the vLLM ones are the odd ones out.Verification: The new changelog block (perf-changelog.yaml:12295) says the re-sweep uses "Inferact/Kimi-K3.1-Pro-DSpark-preview @ 6a2ef20a", but neither recipe pins that revision. Every DSpark
speculative-configin agg-tp8pp2-variants.yaml and disagg-variants.yaml has norevisionkey. The unpinned config is pre-existing in the recipes.