Repository navigation
[VideoGenX] add an end-to-end H3 submission guide / [VideoGenX] 新增 H3 提交全流程指南 - #4885
Merged
Merged
Conversation
4 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A contributor submitting an H3 (VideoGenX) deployment has to assemble the path from
inferencex-e2e/docs/video-generation.md,CONTRIBUTING.md,.github/workflows/README.mdandvideo-generation/README.md. None of them orders the steps from config choice to published result or says who owns each step. For example, the trusted fork dispatch is in.github/workflows/README.md, the/userules are inCONTRIBUTING.md, and the video publication handoff is invideo-generation.md.Changes:
video-generation/SUBMITTING.md(new) gives nine ordered steps and an owner table. The steps cover the deployment choice, the recipe and config row, the local check, the changelog entry, the PR and sweep label, the qualifying run, review and sign-off, reuse and merge, and publication. Each step links the section that owns the detail instead of restating it.VIDEO_RUNTIME_REVISIONinservices[].envis a 40-character commit.video-generation.mdrather than copying them.Reference PSNRREADME section from [VideoGenX] score sweep clips against Diffusers reference videos / [VideoGenX] 将 sweep 视频与 Diffusers 参考视频对比打分 #4659.inferencex-e2e/docs/video-generation.md: the "Contribute a video deployment" section moves into the guide and leaves a pointer. The render step stays in this doc, unchanged, under a newRender a deployment locallyheading. The four-sample B200 History sentence moves beside the historical-evidence sentence.CONTRIBUTING.md: the PR review flow links the guide.No Chinese sibling, because
CONTRIBUTING.mdkeeps Chinese translations only for READMEs. Noperf-changelog.yamlentry, because no benchmark point changes.Testing:
.github/workflows/video-quality.ymlandvideo-generation/README.md#reference-psnrcame with [VideoGenX] score sweep clips against Diffusers reference videos / [VideoGenX] 将 sweep 视频与 Diffusers 参考视频对比打分 #4659, which is now onmain.Limits:
mainuntil [VideoGenX] include video configs in local change detection and rendering / [VideoGenX] 本地变更检测与渲染纳入视频配置 #4886 merges.infx generateexits withhas no srt-slurm pointsandinfx.matrix.changedlists no video keys.VIDEO_RUNTIME_REVISIONfor an image, so the guide states only the format rule.Follows #4659. Pairs with #4886, which makes the linked render step work for video.
PR checklist and change type
Type of Change
Checklist
python -m infx.matrix.changed --base origin/mainlists affected config keys, I have appended one new entry covering them to the physical end ofinferencex-e2e/perf-changelog.yaml; if it lists none, I have added none. I have not edited historical entriesinferencex-e2e/perf-changelog.yamlentry, it carries exactly one primary sweep label (a maintainer applies it on fork PRs):full-sweep-fail-fast(recommended),full-sweep-enabled, ornon-canary-full-sweep-enabled. Optional modifiersall-evals,evals-only, andagentx-fastrequire a primary label; the last two block reuse while applied.OWNER/MEMBER/COLLABORATOR) has commented/use <run_id>(or the legacy/reuse-sweep-run) on this PR. Do this only once there is a final full sweep that is all green with evals passing, since after this comment the primary sweep label will no longer automatically kick off new sweeps. Remove and re-add the primary sweep label to force a new sweep.