Conversation
jooyae
reviewed
May 21, 2021
jooyae
left a comment
jooyae
left a comment
Member
There was a problem hiding this comment.
예진아 과제하느라 고생했어 😊 서버통신 어려웠을텐데도 예진이는 이해력이 정말 빠른 것 같아 멋져멋져
우리조 짱 ~~~~ 👍🏻👍🏻👍🏻
Comment on lines
+4
to
+6
| val repotext1: String, | ||
| val repotext2: String, | ||
| val repotext3: String |
Member
There was a problem hiding this comment.
예진아 여기도 저번에 말했던 것처럼 지금은 이렇게 해도 괜찮지만!! 협업할 때는 repoName, repoExplanation 이렇게 써주면 더 좋을 것 같아 😊😊😊
Member
Author
There was a problem hiding this comment.
아하!! 넵넵 앞으로 이름 주의해서 붙이겠습니다~!!ㅎㅎ
Comment on lines
+28
to
+49
| private fun initButtonClickEvent() { | ||
| binding.button.setOnClickListener{ | ||
| val requestLoginData = RequestLoginData( | ||
| id = binding.idedit.text.toString(), | ||
| password = binding.passedit.text.toString() | ||
| ) | ||
| val call: Call<ResponseLoginData> = ServiceCreator.soptService.postLogin(requestLoginData) | ||
| call.enqueue(object : Callback<ResponseLoginData> { | ||
| override fun onResponse( | ||
| call: Call<ResponseLoginData>, | ||
| response: Response<ResponseLoginData> | ||
| ){ | ||
| if(response.isSuccessful){ | ||
| val data = response.body()?.data | ||
| Toast.makeText(this@SignInActivity, "로그인 성공", Toast.LENGTH_SHORT).show() | ||
| startHomeActivity() | ||
| }else { | ||
| Toast.makeText( | ||
| this@SignInActivity, | ||
| "아이디/비밀번호를 확인해주세요!", | ||
| Toast.LENGTH_SHORT | ||
| ).show() |
Member
There was a problem hiding this comment.
👍🏻 좋아요 !!!! Callback 서버통신 연습해보다가 혹시 더 공부하고 싶으면 Rxjava 문법으로 좀 다르게 구현할 수 있는데 참고해봤으면 좋겠어 ~~~!!
Member
Author
There was a problem hiding this comment.
오호 Rxjava 문법 한 번 공부해보겠습니당~~!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.