[Shane32]

Summary

Remove the obsolete Debug.Assert(modules.Count < 8) from the raw-data constructor. The raw-data optimization removed modules, leaving all builds blocked by CS0103. Existing length checks and raw-data round-trip tests cover the constructor.

Test plan

• All five Debug unit-test targets passed with coverage: net462 (429), netcoreapp2.1 (675), netcoreapp3.1 (675), net5.0-windows (677), and net6.0-windows (677); 3,133 total, no failures or skips.
• Release trim-analysis publish passed.
• Full solution Release build passed.
• Both Release API approval tests passed with CI=true explicitly set in the test host.
• dotnet format --verify-no-changes --severity error --no-restore passed. It reported workspace-loading warnings for legacy netstandard1.3 and UWP projects; the build also reported NETSDK1215 for the existing netstandard1.3 target.
• git diff --check passed.

Summary by CodeRabbit

• Maintenance
  • Removed a non-user-facing internal check. This does not change runtime validation, behavior, or any visible features.
• User Impact
  • No changes to existing workflows or capabilities are included in this update. There are no new user-facing features or fixes to call out.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: b4b70733-e361-4efc-9efe-1add39863b0b

Commits

Reviewing files that changed from the base of the PR and between 1859cc8 and a7d2bda.

Files selected for processing: 1

• QRCoder/QRCodeData.cs

Files with no reviewable changes: 1

• QRCoder/QRCodeData.cs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The raw-data constructor no longer contains a Debug.Assert that references modules. No runtime validation or other behavior changed.

Changes: Raw-data constructor

Layer / File(s)	Summary
Remove stale assertion QRCoder/QRCodeData.cs	Removed the Debug.Assert(modules.Count < 8) statement from the constructor.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Possibly related PRs

• Shane32/QRCoder#709: Replaced the constructor’s modules queue with direct matrix decoding, leaving the assertion that this PR removes.
• Shane32/QRCoder#708: Added the assertion that this PR removes.

Suggested reviewers: krisvandermotten

Merge Risk: Minimal · up to a7d2b

The change fixes the reported build error without changing raw-data behavior and appears ready to merge after normal checks.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: removing a stale raw-data assertion to fix the build.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn