patience/.pre-commit-config.yaml at main · ShaneIsley/patience · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
# Pre-commit hooks for patience project
# Prevents regression of TDD cycle fixes at commit time
# Install with: pre-commit install

repos:
  # Go formatting and imports
  - repo: https://github.com/dnephin/pre-commit-golang
    rev: v0.5.1
    hooks:
      - id: go-fmt
        name: Format Go code
        description: Runs gofmt to format Go code
      - id: go-imports
        name: Fix Go imports
        description: Runs goimports to fix imports
      - id: go-mod-tidy
        name: Tidy Go modules
        description: Runs go mod tidy to clean up modules
      - id: go-vet-mod
        name: Go vet
        description: Runs go vet to catch common errors
      - id: go-unit-tests-mod
        name: Run Go unit tests
        description: Runs go test to ensure tests pass

  # Comprehensive linting - prevents all TDD cycle regressions
  - repo: local
    hooks:
      - id: golangci-lint
        name: golangci-lint (comprehensive quality checks)
        description: Prevents regression of all TDD cycle fixes
        entry: golangci-lint
        args: [run, --config=.golangci.yml, --timeout=5m]
        language: system
        files: \.go$
        pass_filenames: false

      # TDD Cycle 1 regression prevention - function complexity
      - id: check-function-complexity
        name: Function complexity check
        description: Prevents regression of 216-line method fix
        entry: bash
        args:
          - -c
          - |
            RUN_METHOD_LINES=$(sed -n '/^func (e \*Executor) Run(/,/^}/p' pkg/executor/executor.go | wc -l)
            if [ "$RUN_METHOD_LINES" -gt 130 ]; then
              echo "ERROR: Executor.Run method is too long ($RUN_METHOD_LINES lines)"
              exit 1
            fi
            echo "✅ Function complexity OK"
        language: system
        files: pkg/executor/executor\.go$
        pass_filenames: false

      # TDD Cycle 1 regression prevention - magic numbers
      - id: check-constants-file
        name: Constants file check
        description: Prevents regression of magic numbers fix
        entry: bash
        args:
          - -c
          - |
            if [ ! -f "pkg/executor/constants.go" ]; then
              echo "ERROR: constants.go file missing - magic numbers may have been reintroduced"
              exit 1
            fi
            echo "✅ Constants file exists"
        language: system
        files: pkg/executor/.*\.go$
        pass_filenames: false

      # TDD Cycle 3 regression prevention - concurrency safety
      - id: check-mutex-usage
        name: Concurrency safety check
        description: Prevents regression of race condition fixes
        entry: bash
        args:
          - -c
          - |
            MUTEX_USAGE=$(grep -r "sync\.\(Mutex\|RWMutex\)" pkg/ | wc -l)
            if [ "$MUTEX_USAGE" -lt 5 ]; then
              echo "ERROR: Insufficient mutex usage - concurrency safety may be compromised"
              exit 1
            fi
            echo "✅ Concurrency safety maintained"
        language: system
        files: \.go$
        pass_filenames: false

      # TDD Cycle 4 regression prevention - type safety
      - id: check-interface-usage
        name: Type safety check
        description: Prevents regression of interface{} elimination
        entry: bash
        args:
          - -c
          - |
            INTERFACE_USAGE=$(grep -r "interface{}" pkg/ | grep -v "_test.go" | wc -l)
            if [ "$INTERFACE_USAGE" -gt 50 ]; then
              echo "ERROR: Too many interface{} usages ($INTERFACE_USAGE) - type safety regression"
              exit 1
            fi
            echo "✅ Type safety maintained ($INTERFACE_USAGE usages - mostly JSON/config)"
        language: system
        files: \.go$
        pass_filenames: false

  # General code quality
  - repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.4.0
    hooks:
      - id: trailing-whitespace
        name: Remove trailing whitespace
      - id: end-of-file-fixer
        name: Fix end of files
      - id: check-yaml
        name: Check YAML syntax
      - id: check-toml
        name: Check TOML syntax
      - id: check-merge-conflict
        name: Check for merge conflicts
      - id: check-added-large-files
        name: Check for large files
        args: ['--maxkb=1000']

# Configuration
default_stages: [commit]
fail_fast: false
minimum_pre_commit_version: '2.20.0'