Skip to content

Trim table headings used as card labels (2.22.1) - #70

Merged
HarryCordewener merged 1 commit into
mainfrom
claude/project-thread-i4t2iz-linear-labels
Oct 23, 2026
Merged

HarryCordewener merged 1 commit into
mainfrom
claude/project-thread-i4t2iz-linear-labels

Conversation

@HarryCordewener

@HarryCordewener HarryCordewener commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

A Table read as cards (linear for a screen reader, or too narrow for its columns) used each heading as the field label as it was. SharpMUSH's WHO pads its Idle heading so the column lines up, and a screen reader heard Idle : 59s.

Table.DrawCards now trims the spaces around a heading before it becomes a label. The table's own heading row is unchanged.

Tests

  • FieldsAndTreeTests.Table_Linear_LabelsEachCellWithoutTheHeadingsPadding: fails before the change (Idle : 59s), passes after.
  • Full suite: 1367 passed.

SharpMUSH picks this up by bumping MarkupStringVersion once 2.22.1 is tagged.


Generated by Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Labels in tables displayed as cards now omit extra spaces from column headings. For example, a heading with trailing whitespace appears as Idle: 59s instead of Idle : 59s, making label-value pairs cleaner in linear or narrow table layouts.

A heading padded to line its column up ("Idle ") read "Idle : 59s" to a
screen reader and in narrow card layouts.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015YDiaApsFRN4PnfRwGRp7i
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: 58cb443d-7e0a-422a-bcb4-b506091038b8
📥 Commits

Reviewing files that changed from the base of the PR and between a02aecd and 6bde1e0.

📒 Files selected for processing: 3
  • CHANGELOG.md
  • MarkupString.Tests/Layout/FieldsAndTreeTests.cs
  • MarkupString/Layout/Blocks/Table.cs

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

DrawCards now trims whitespace from column headers before using them as card labels. A test checks the linear table output, and the changelog describes the fix.

Changes

Table card labels

Layer / File(s) Summary
Trim headers used as card labels
MarkupString/Layout/Blocks/Table.cs, MarkupString.Tests/Layout/FieldsAndTreeTests.cs, CHANGELOG.md
DrawCards trims both ends of each header. A test checks that "Idle " renders as Idle: 59s, and the changelog records the fix.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to 6bde1

The scoped formatting fix is mergeable with no identified correctness or availability risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: trimming table headings used as card labels.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants