Skip to content

Fix dead widget when omarchy.notifications has been cloned #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pabg92 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix dead widget when omarchy.notifications has been cloned #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion BarWidget.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,16 @@ BarWidget {
}

// Look up the long-running notifications service through the shell host.
// firstPartyServiceFor() is a plain lookup keyed by the id the service is
// actually enabled under, so `omarchy plugin clone omarchy.notifications`
// would leave us with nothing. Ask the registry which id is live first;
// hosts without resolveEnabledId keep using the built-in id as before.
readonly property var hostShell: bar && bar.shell ? bar.shell : null
readonly property string notificationServiceId: hostShell && hostShell.pluginRegistry
&& typeof hostShell.pluginRegistry.resolveEnabledId === "function"
? hostShell.pluginRegistry.resolveEnabledId("omarchy.notifications") : "omarchy.notifications"
readonly property var notificationService: hostShell && hostShell.firstPartyServiceFor
? hostShell.firstPartyServiceFor("omarchy.notifications") : null
? hostShell.firstPartyServiceFor(root.notificationServiceId) : null

readonly property int liveCount: notificationService && notificationService.popupModel
? notificationService.popupModel.count : 0
Expand Down