Add repository and deployment links - #84
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds discovery links for the project by surfacing the repository in the app’s sidebar navigation and publishing the live Railway deployment URL in the README, with a small AppShell test update to cover the new navigation link.
Changes:
- Add a prominent Railway deployment link near the top of
README.md. - Add a GitHub repository link to the AppShell sidebar navigation.
- Extend the AppShell test to assert the GitHub link and its
href.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Adds a top-level link to the live Railway deployment. |
| frontend/src/app/AppShell.tsx | Adds a GitHub repository link to the sidebar navigation. |
| frontend/src/app/AppShell.test.tsx | Adds a test assertion for the new GitHub navigation link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (3)
frontend/src/app/AppShell.tsx:103
- This link opens a new tab via target="_blank" but the accessible name doesn’t indicate that behavior. Consider adding an aria-label that includes “opens in a new tab” so screen-reader users aren’t surprised.
<a className="nav-link" href={githubUrl} target="_blank" rel="noopener noreferrer">
README.md:11
- The README now presents a one-click link to the public deployment before the existing warning about not entering real financial data into untrusted deployments. To reduce the chance users miss the warning, consider adding a short caution immediately adjacent to the deployment link.
**[Open Tax Tracker on Railway](https://shoginn-tax-tracker.up.railway.app)**
frontend/src/app/AppShell.test.tsx:23
- If the GitHub link’s accessible name is updated to mention opening a new tab, this test should query by the new accessible name to match user-facing semantics.
expect(screen.getByRole("link", { name: "GitHub" })).toHaveAttribute(
"href",
"https://github.com/ShoGinn/tax-tracker",
);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification