Skip to content

Commit 087dc01

Browse files
committed
Check named definitions in documentation schemas
1 parent 0806daa commit 087dc01

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

‎packages/cli/src/cli/commands/doc/fetch.test.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,10 @@ describe('doc fetch command', () => {
156156
})
157157
const schema = JSON.parse(stdout())
158158
expect(schema.definitions.Result.anyOf).toHaveLength(2)
159-
expect(schema.definitions.Result.anyOf[0].properties.document.properties.content.type).toBe('string')
160-
expect(schema.definitions.Result.anyOf[1].properties.format.const).toBe('markdown')
159+
expect(schema.definitions.Result.anyOf[0].properties.document).toEqual({$ref: '#/definitions/Document'})
160+
expect(schema.definitions.Document.properties.content.type).toBe('string')
161+
expect(schema.definitions.Result.anyOf[1]).toEqual({$ref: '#/definitions/DocumentFile'})
162+
expect(schema.definitions.DocumentFile.properties.format.const).toBe('markdown')
161163
expect(stderr()).toBe('')
162164
expect(fetch).not.toHaveBeenCalled()
163165
})

‎packages/cli/src/cli/commands/doc/search.test.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,10 @@ describe('doc search command', () => {
177177
})
178178
const schema = JSON.parse(stdout())
179179
expect(schema.definitions.Result.required).toEqual(['results', 'pageInfo'])
180-
expect(schema.definitions.Result.properties.results.items.properties.domain.type).toEqual(['string', 'null'])
180+
expect(schema.definitions.Result.properties.results.items).toEqual({
181+
$ref: '#/definitions/DocumentationSearchEntry',
182+
})
183+
expect(schema.definitions.DocumentationSearchEntry.properties.domain.type).toEqual(['string', 'null'])
181184
expect(schema.definitions.Result.additionalProperties).toBe(false)
182185
expect(stderr()).toBe('')
183186
expect(shopifyFetch).not.toHaveBeenCalled()

0 commit comments

Comments
 (0)