Repository navigation
Bump pinned Node versions to the Oct 21 security releases - #8982
Merged
Merged
Conversation
The Oct 21 Node.js security releases (22.23.4, 24.22.1, 26.12.1) fix high-severity issues in TLS hostname checks for non-canonical IPs, dns.resolve with NUL bytes, and an out-of-bounds write in Brotli. Every Node version pinned in this repo was on an affected release. None of these pins ship to users; they only control what developers run locally (.nvmrc, dev.yml) and what CI runs (workflow pins and the test matrix). Move all of them to the patched release in their line: 22.12.0 -> 22.23.4 24.1.0 -> 24.22.1 24.12.0 -> 24.22.1 26.1.0 -> 26.12.1 Deliberately unchanged: - engines.node (>=22.12.0) in package.json files: this is the user-facing minimum supported version, a product decision rather than a CVE fix. - pages.yml node-version "22": major-only pin, already resolves to the latest (patched) 22.x. - @types/node and test fixtures: not runtime versions.
4 tasks done
Contributor
Author
|
The |
isaacroldan
approved these changes
Oct 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The Oct 21 Node.js security releases — 22.23.4, 24.22.1 and 26.12.1 — fix high-severity issues in TLS hostname checks for non-canonical IP addresses,
dns.resolvewith NUL bytes, and an out-of-bounds write in Brotli.Every Node version pinned in this repo (as of
main@8fa26af) was on an affected release. None of these pins reach users — the CLI doesn't ship Node — they only control what our own developers run locally and what CI runs. This PR moves all of them to the patched release in their line.Context: Slack thread
WHAT is this pull request doing?
Pure version-string bumps, no logic changes:
26.1.026.12.1.nvmrc,dev.yml,DEFAULT_NODE_VERSIONintests-pr/tests-main/tests-manual, test matrices +if:guards,maintenance-prs,gardener-backlog-prs,update-graphql-deps24.12.024.22.1release.yml(3 jobs)24.1.024.22.1PLAYWRIGHT_NODE_VERSION, test matrices22.12.022.23.4tests-pr,tests-main,tests-manual)All three target versions are confirmed present on the Node release index as
security: truereleases and are the latest in their lines. The shardinginclude/excludeentries intests-pr.ymland thematrix.node == …guards intests-main.ymlwere updated in lockstep so they still match the matrix.Deliberately unchanged (audited, not pins of a runtime we install):
engines.node: ">=22.12.0"in thepackage.jsonfiles — this is the user-facing minimum supported version. Raising it would be a product/breaking-change decision, not a CVE fix.pages.ymlnode-version: "22"— major-only pin, already resolves to the latest (patched) 22.x.@types/nodeandnode_versionvalues in test fixtures — not runtime versions.Note
Reviewer call-out: the
22.12.0matrix entry matchedengines.node, so it may have been giving us exact-minimum-version coverage. Bumping it to22.23.4means CI no longer exercises the floor, and 22.x minor releases can add APIs that 22.12 lacks. If we'd rather keep that coverage, the alternative is to leave22.12.0in the matrix only (ephemeral CI runners executing trusted code are low-risk for these specific CVEs) and bump everything else. Happy to go either way.How to manually test your changes?
nvm use/dev upshould now install Nodev26.12.1.tests-manual.ymlviaworkflow_dispatchand confirm the Node version dropdown offers22.23.4/24.22.1/26.12.1.Checklist