Repository navigation
fix(gem): preserve runtime-defined mixin scopes - #2745
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2598. Tapioca skips GObject interfaces created by
gobject-introspectionbecause their recorded source belongs to that gem, even when another gem mixes them into its own namespace. The generated RBI is then missing the module declaration.Implementation
When a gem mixes in a module that would otherwise be filtered as external, emit a foreign scope only if it is nested under a namespace defined by that gem. Other dependency mixins remain filtered.
Tests
The regression failed before the fix because the RBI omitted the module declaration. The full test suite passed: 867 tests, 3,466 assertions, 0 failures, 2 skips. Typecheck, lint, gem RBI verification and shim checks passed.