Repository navigation
Skip constants nested under payload aliases - #2754
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
amomchilov
reviewed
Oct 29, 2026
| parts.pop | ||
|
|
||
| parts.each_index.any? do |index| | ||
| namespace = T.must(parts[0..index]).join("::") |
Contributor
There was a problem hiding this comment.
Suggested change
| namespace = T.must(parts[0..index]).join("::") | |
| namespace = parts.first(index).join("::") |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2738. Sorbet rejects constants nested under payload aliases such as
YAML::LOADER_VERSIONbecauseYAMLis already defined asPsych.Implementation
Skip nested constants when an ancestor namespace is a payload alias, so Tapioca does not emit an RBI definition under the alias name.
Tests
bin/test spec/tapioca/gem/pipeline_spec.rb(140 tests, 443 assertions; 1 skipped)bin/typecheckbin/styleyaml0.4.0; the generated RBI is empty andsrb tc --no-configpasses.