Skip to content

strip-to-slot: center pins around y=0 - #323

Open
mustafacc wants to merge 8 commits into
SiEPIC:masterfrom
mustafacc:master
Open

strip-to-slot: center pins around y=0#323
mustafacc wants to merge 8 commits into
SiEPIC:masterfrom
mustafacc:master

Conversation

@mustafacc

Copy link
Copy Markdown
Member

Slight changes to geometry to make the cell symmetric around y. makes things a lot easier for connect_cell transformations...

Before:
image

After:
image

Slight changes to geometry to make the cell symmetric around y. makes
things a lot easier for connect_cell transformations...
@codecov-commenter

codecov-commenter commented Feb 14, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.33%. Comparing base (dfca8a4) to head (b24db10).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   73.33%   73.33%           
=======================================
  Files         105      105           
  Lines       12730    12730           
=======================================
  Hits         9336     9336           
  Misses       3394     3394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukasc-ubc

Copy link
Copy Markdown
Member

Any simulations on the insertion loss? How do the two cells compare?

@lukasc-ubc

Copy link
Copy Markdown
Member

@mustafacc ?

@mustafacc

Copy link
Copy Markdown
Member Author

I don't think they'd be any different, other than the direction of the waveguides; but in any case I simulated both

pre-commit
image

post-commit
image

image

@lukasc-ubc

Copy link
Copy Markdown
Member

One possibility is that the slot waveguide loss will be higher for the diagonal design, due to the quantization of the EBL. It may be interesting to compare and see if there is a difference.

Given that it is a relatively large change to the design, my suggestion is to have two separate cells, rather than modifying the existing one.

e.g., strip-to-slot, strip-to-slot-v2.

@lukasc-ubc

Copy link
Copy Markdown
Member

@mustafacc could you make two versions?

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants