Repository navigation
Fix drawing font loading after Monaco initializes - #148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Draw after Monaco loads can crash Excalidraw font loading with
TypeError: Ii.default is not a constructor. The bundledes6-promise-poolUMD wrapper chooses Monaco’s global AMD loader before its own CommonJS export. Pin a small package patch that prefers the CommonJS module when present, while retaining standalone AMD and browser-global fallbacks. No dependency version or application layout changes.The regression executes the installed dependency source with both loaders: it fails on the original package and passes with the patch, including actual queued work and both fallback cases. Frozen install, typecheck and compiled390/768/1440 checks pass: Monaco AMD remains active, Excalifont loads, drawing text persists in isolated browser storage, and the drawing reopens without page errors or document overflow. Screenshots reviewed; no production data or inference calls. Normal CI remains required.
Release prerequisite: constrain existing DOMPurify instances to3.4.17, the upstream fix for GHSA-cg2g-xh64-v4q7 and GHSA-mrv2-3pqr-j5jr. The affected lockfile paths are PostHog, Excalidraw/Mermaid and Monaco. No new dependency, audit exception or policy threshold change. This qualifies the installed/bundled dependency graph; it does not certify separately CDN-hosted third-party bundles.