Skip to content

Commit 8748f8a

Browse files
merge: withdraw the iron-core beta qualifier
Beta is by definition a plasma quantity, and beta as a prefix for a geometric angle was already tried and retired here: beta_angle_of_ferritic_element and beta_angle_of_passive_loop are both superseded in favour of tilt_angle and vertical_angle spellings. No shipped name used the token, so the removal is clean.
2 parents 59754b7 + 4796155 commit 8748f8a

4 files changed

Lines changed: 3 additions & 24 deletions

File tree

imas_standard_names/grammar/model_types.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,6 @@ class Qualifier(StrEnum):
248248
ENHANCEMENT = "enhancement"
249249
REQUESTED = "requested"
250250
EJIMA = "ejima"
251-
BETA_INCLINATION = "beta_inclination"
252251
MHD = "mhd"
253252
WAVE = "wave"
254253
FAST_WAVE = "fast_wave"

imas_standard_names/grammar/vocabularies/qualifier_categories.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ qualifier_categories:
3939

4040
# Geometric, directional, and tensor qualifiers
4141
geometry:
42-
- beta_inclination
4342
- contravariant
4443
- covariant
4544
- cross_field

imas_standard_names/grammar/vocabularies/qualifiers.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,6 @@
208208

209209
# --- Named parameters ---
210210
- ejima # Ejima (volt-second consumption coefficient)
211-
- beta_inclination # beta angle of an oblique iron-core segment
212211

213212
# --- Physics regime / type ---
214213
# NOTE: 'internal' removed — internal_inductance and internal_energy are now

tests/test_vocabulary_gap_tokens.py

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Closed-vocabulary coverage for DD-backed quantity families.
22
3-
Three accepted additions are intentionally additive, while the strain-gauge
3+
Two accepted additions are intentionally additive, while the strain-gauge
44
candidate is rejected on positive evidence:
55
66
* Rejected: ``measurement_direction_unit_vector``. Accepted alternatives:
@@ -21,16 +21,10 @@
2121
* ``relative_humidity`` is the dimensionless fraction of humidity from zero to
2222
one measured at the X-ray detector, as documented for
2323
``camera_x_rays/detector_humidity`` (unit ``1``).
24-
* ``beta_inclination`` qualifies ``angle`` for the beta-labelled second
25-
inclination of an oblique iron-core segment. DD documents counter-clockwise
26-
inclination from upward ``grad Z``; its unit history corrects ``m`` to
27-
``rad``. The corresponding sibling pattern is ``alpha_inclination``.
28-
2924
The shipped catalog snapshot contains none of the representative identities for
30-
the three accepted additions or an equivalent token in those families.
25+
the two accepted additions or an equivalent token in those families.
3126
Unindexed ``stokes_parameter`` erases which polarization coordinate is stored;
32-
generic fractions do not say relative humidity; and bare ``beta`` denotes
33-
normalized plasma pressure rather than an iron-core geometric inclination.
27+
generic fractions do not say relative humidity.
3428
"""
3529

3630
from dataclasses import replace
@@ -44,7 +38,6 @@
4438
@pytest.mark.parametrize(
4539
("registry", "tokens"),
4640
[
47-
("qualifiers", {"beta_inclination"}),
4841
("component_axes", {"s0", "s1", "s2", "s3"}),
4942
("bases", {"relative_humidity"}),
5043
],
@@ -54,11 +47,6 @@ def test_dd_backed_tokens_are_registered(registry: str, tokens: set[str]) -> Non
5447
assert tokens <= getattr(vocabularies, registry)
5548

5649

57-
def test_beta_inclination_joins_the_geometry_qualifier_family() -> None:
58-
vocabularies = load_default_vocabularies()
59-
assert vocabularies.qualifier_categories["beta_inclination"] == "geometry"
60-
61-
6250
@pytest.mark.parametrize(
6351
"name",
6452
[
@@ -67,7 +55,6 @@ def test_beta_inclination_joins_the_geometry_qualifier_family() -> None:
6755
"s2_stokes_parameter_of_fiber_optic_current_sensor",
6856
"s3_stokes_parameter_of_fiber_optic_current_sensor",
6957
"relative_humidity_of_detector",
70-
"beta_inclination_angle_of_iron_core_segment",
7158
],
7259
)
7360
def test_dd_backed_vocabulary_name_round_trips_through_render(name: str) -> None:
@@ -78,11 +65,6 @@ def test_dd_backed_vocabulary_name_round_trips_through_render(name: str) -> None
7865
@pytest.mark.parametrize(
7966
("registry", "token", "name"),
8067
[
81-
(
82-
"qualifiers",
83-
"beta_inclination",
84-
"beta_inclination_angle_of_iron_core_segment",
85-
),
8668
(
8769
"component_axes",
8870
"s0",

0 commit comments

Comments
 (0)