triv: #no-task mcp logging (#193)

* triv: #no-task mcp logging

* triv: #no-task mcp logging

* triv: #no-task mcp logging

* triv: #no-task mcp logging

* triv: #no-task mcp logging

Author: LuboZ

src/django_smartbase_admin/locale/sk/LC_MESSAGES/django.mo

@@ -1192,3 +1192,122 @@ msgstr "Strana"
 msgctxt "pagination"
 msgid "Go"
 msgstr "Prejsť"
+
+# MCP request log / AI Assistant Module dashboard
+
+msgid "AI Assistant Module"
+msgstr "AI asistent"
+
+msgid "Calls"
+msgstr "Volania"
+
+msgid "Errors"
+msgstr "Chyby"
+
+msgid "Avg duration (ms)"
+msgstr "Priem. trvanie (ms)"
+
+msgid "Items returned"
+msgstr "Vrátené položky"
+
+msgid "Request (KB)"
+msgstr "Požiadavka (KB)"
+
+msgid "Response (KB)"
+msgstr "Odpoveď (KB)"
+
+msgid "No data"
+msgstr "Žiadne dáta"
+
+msgid "Recent calls"
+msgstr "Posledné volania"
+
+msgid "Time"
+msgstr "Čas"
+
+msgid "Tool"
+msgstr "Nástroj"
+
+msgid "Duration (ms)"
+msgstr "Trvanie (ms)"
+
+msgid "Error"
+msgstr "Chyba"
+
+msgid "Request"
+msgstr "Požiadavka"
+
+msgid "Response"
+msgstr "Odpoveď"
+
+msgid "Request size (B)"
+msgstr "Veľkosť požiadavky (B)"
+
+msgid "Response size (B)"
+msgstr "Veľkosť odpovede (B)"
+
+msgid "Result status"
+msgstr "Stav výsledku"
+
+msgid "Total"
+msgstr "Spolu"
+
+msgid "Fields"
+msgstr "Polia"
+
+msgid "Inlines"
+msgstr "Vnorené"
+
+msgid "Inline rows"
+msgstr "Riadky vnorených"
+
+msgid "Error type"
+msgstr "Typ chyby"
+
+msgid "Error message"
+msgstr "Chybová správa"
+
+msgid "Last %(days)s days"
+msgstr "Posledných %(days)s dní"
+
+msgid "Duration"
+msgstr "Trvanie"
+
+msgid "Changed"
+msgstr "Zmenené"
+
+msgid "rows"
+msgstr "riadkov"
+
+msgid "Audit log"
+msgstr "Audit"
+
+msgid "Record count"
+msgstr "Počet záznamov"
+
+msgid "Detail field count"
+msgstr "Počet polí detailu"
+
+msgid "Detail inline count"
+msgstr "Počet inlinov detailu"
+
+msgid "Detail inline rows"
+msgstr "Riadky inlinov detailu"
+
+msgid "Returned field count"
+msgstr "Počet vrátených polí"
+
+msgid "Returned inline count"
+msgstr "Počet vrátených inlinov"
+
+msgid "Returned inline rows"
+msgstr "Počet vrátených riadkov inlinov"
+
+msgid "MCP calls"
+msgstr "MCP volania"
+
+msgid "Grouping"
+msgstr "Zoskupenie"
+
+msgid "By user"
+msgstr "Podľa používateľa"

src/django_smartbase_admin/locale/sk/LC_MESSAGES/django.po

@@ -37,6 +37,9 @@
 ``list_rows`` requires non-empty ``fields``. Write results:
 ``{"status": "ok", ...}`` or ``{"status": "invalid", "errors": ...}`` (no DB change).
 Inline dict keys use ``inline_name`` from ``list_admins`` (inline class name).
+Send nested arguments (``inlines``, ``field_values``, ``object_ids``, ``filter_data``,
+``sort``) as real JSON objects/arrays, never stringified JSON; pass ids as JSON
+numbers exactly as returned (e.g. ``174``, not ``"174"``) so rows match.
 Create flow: ``fetch_add_form`` then ``create_object``; inline FK ids on add often
 need ``autocomplete`` on another admin with the same ``filter.target_model``.
 

src/django_smartbase_admin/mcp/instructions.py

@@ -259,16 +259,40 @@ def _guarded_tool_call(method):
     leaks across calls and tests, causing audit rows to be written under
     stale users.
     """
+    import time
     from functools import wraps
 
+    from django_smartbase_admin.mcp.signals import mcp_tool_called
+
     @wraps(method)
     def wrapper(self, *args, **kwargs):
-        if not sb_admin_site.has_permission(self.request):
-            raise PermissionDenied
+        start = time.perf_counter()
+        result = None
+        error = None
         try:
-            return method(self, *args, **kwargs)
+            if not sb_admin_site.has_permission(self.request):
+                raise PermissionDenied
+            result = method(self, *args, **kwargs)
+            return result
+        except Exception as exc:
+            error = exc
+            raise
         finally:
+            # Clear the bound request BEFORE notifying listeners so a logging
+            # receiver's own DB writes don't run inside the SBAdmin/audit
+            # context (which would emit an AdminAuditLog row per log row).
             SBAdminThreadLocalService.clear_request()
+            # send_robust: a failing receiver must not break the tool call.
+            mcp_tool_called.send_robust(
+                sender=type(self),
+                request=getattr(self, "request", None),
+                tool_name=method.__name__,
+                tool_args=args,
+                tool_kwargs=kwargs,
+                result=result,
+                error=error,
+                duration_ms=int((time.perf_counter() - start) * 1000),
+            )
 
     wrapper.sbadmin_mcp_tool = True
     return wrapper
@@ -967,14 +991,18 @@ def update_detail(
             fetched payload back. Unknown or readonly names raise
             ``LookupError``.
           inlines: ``{inline_name: [row_op, ...]}`` keyed by the same
-            ``inline_name`` used by ``fetch_detail``. Each op is:
+            ``inline_name`` used by ``fetch_detail``. Pass it as a real
+            JSON object/array — never a stringified one. Each op is:
 
             * ``{"id": <pk>, ...overrides}`` — update an existing row.
             * ``{"id": <pk>, "_delete": true}`` — delete the row.
             * ``{...field values}`` (no ``id``) — create a new row.
 
-            Inlines not mentioned are passed through unchanged. Unknown
-            inline names or row ids raise ``LookupError``.
+            ``id`` is the **integer** pk exactly as ``fetch_detail``
+            returns it — send it as a JSON number (``174``), not a string
+            (``"174"``), or the row won't match. Inlines not mentioned are
+            passed through unchanged. Unknown inline names or row ids raise
+            ``LookupError``.
 
         Returns ``{"status": "ok", "id": ..., "fields": ...,
         "inlines": ...}`` mirroring ``fetch_detail`` after the save, or

src/django_smartbase_admin/mcp/mcp.py

@@ -647,7 +647,15 @@ def _detail_form_value(cls, bound_field, request):
             if not value:
                 return []
             ids = list(value)
-            objects = {item.pk: item for item in form_field.queryset.filter(pk__in=ids)}
+            try:
+                objects = {
+                    item.pk: item for item in form_field.queryset.filter(pk__in=ids)
+                }
+            except (ValueError, TypeError):
+                # An id that can't match the related pk type (e.g. a non-numeric
+                # value where the pk is integer) must not 500 the read-back; it
+                # falls back to str() below as an unresolved id.
+                objects = {}
             # Preserve submitted order; unresolved ids fall back to str()
             # rather than getting silently dropped.
             return [

src/django_smartbase_admin/mcp/service.py

@@ -0,0 +1,9 @@
+"""Signals emitted by the MCP tool layer.
+
+``mcp_tool_called`` fires once per dispatched tool. Receiver kwargs:
+    request, tool_name, tool_args, tool_kwargs, result, error, duration_ms
+"""
+
+import django.dispatch
+
+mcp_tool_called = django.dispatch.Signal()

src/django_smartbase_admin/mcp/signals.py

@@ -0,0 +1,29 @@
+from django.apps import AppConfig
+
+
+class MCPLogConfig(AppConfig):
+    """Optional MCP request logging.
+
+    Opt-in via ``INSTALLED_APPS``; ``ready()`` connects the logger to
+    ``mcp_tool_called`` and registers the admin view. The host project
+    schedules retention (``MCPRequestLog.prune``).
+    """
+
+    name = "django_smartbase_admin.mcp_log"
+    label = "sbadmin_mcp_log"
+    verbose_name = "SBAdmin MCP Log"
+    default_auto_field = "django.db.models.BigAutoField"
+
+    def ready(self):
+        from django_smartbase_admin.admin.site import sb_admin_site
+        from django_smartbase_admin.mcp.signals import mcp_tool_called
+        from django_smartbase_admin.mcp_log.models import MCPRequestLog
+        from django_smartbase_admin.mcp_log.logger import on_mcp_tool_called
+        from django_smartbase_admin.mcp_log.sb_admin import MCPRequestLogAdmin
+
+        mcp_tool_called.connect(
+            on_mcp_tool_called, dispatch_uid="sbadmin_mcp_log_logger"
+        )
+
+        if not sb_admin_site.is_registered(MCPRequestLog):
+            sb_admin_site.register(MCPRequestLog, MCPRequestLogAdmin)