Repository navigation
Conversation
|
Invitation URL: |
|
zigbee-range-extender_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 572c238 |
Test Results 73 files 546 suites 0s ⏱️ Results for commit 572c238. ♻️ This comment has been updated with latest results. |
- Add a reusable range-extender-signal profile with signalStrength and refresh - Report RSSI and LQI from Basic cluster responses - Reuse manual refresh and existing five-minute polling for signal sampling - Select the sub-driver by capability rather than manufacturer or model - Update the Dongle-LMG21 fingerprint to use the new profile - Add integration tests for sampling, profile changes, and device matching Validation: all 22 integration tests pass; luacheck reports no warnings or errors.
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Profile category check: ✅ Passed - all profiles have a category defined. |
KKlimczukS
reviewed
Nov 2, 2026
aleclorimer
reviewed
Nov 2, 2026
- Set min_api_version to 17 for all new tests - Match the sub-driver using manufacturer and model fingerprints - Add an extensible fingerprint list for supported range extenders - Verify that unmatched manufacturers and models are rejected Validation: all 22 tests pass; luacheck reports no warnings or errors.
…int' into add-sonoff-dongle-lmg21-fingerprint
aleclorimer
approved these changes
Nov 3, 2026
KKlimczukS
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Add a fingerprint for the SONOFF Dongle-LMG21 running Zigbee router firmware to the existing
zigbee-range-extenderdriver.SONOFFDongle-LMG21SONOFF Zigbee Range Extenderrange-extenderThis change reuses the existing driver implementation and device profile. No Lua code, capabilities, or device profiles are changed.
Summary of Completed Tests
Manually tested with a SONOFF Dongle-LMG21 running custom-built Zigbee router firmware and a SmartThings Hub V3.
Verified in the SmartThings app that:
SONOFF Zigbee Range Extender.SONOFFandDongle-LMG21, matching the new fingerprint.Zigbee Range Extenderdriver distributed throughSONOFF Router Test Channel.The screenshots below show the assigned driver, device information, connection status, and connection path.
These checks cover device onboarding and driver association. Routing traffic for other Zigbee devices was not verified as part of these checks.
