Repository navigation
Matter Switch: add default fingerprint tables to profiling logic - #3316
Conversation
|
Channel deleted. |
|
matter-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against a5831fc |
Test Results 73 files 546 suites 0s ⏱️ Results for commit a5831fc. |
There was a problem hiding this comment.
Did you manually check the AI on all these values? It probably did it with scripts, to ensure correctness programanatically, but the biggest risk with this change IMO is somethi8ng missing or something extra included in these maps.
There was a problem hiding this comment.
Yes, actually- I did all of them manually months ago, but then never followed up with the PR. Then I had AI double check my own work rather than the other way around. Agreed on your assessment
| vendorId: 0x100b | ||
| productId: 0x2168 | ||
| deviceProfileName: light-color-level-2200K-6500K | ||
| deviceProfileName: light-color-level |
There was a problem hiding this comment.
Why are these profiles changing? Is this what they should have been to enable dynamic profile switching?
There was a problem hiding this comment.
They actually aren't changing- the default color temp range on the "default" profile is 2200-6500K, exactly the same as this. This profile is identical to the default. So now these devices wouldn't even need to "re-profile" dynamically, since the profile is literally identical. This is mostly a cleanup effort, to clarify what is expected, but it does also drop one extra step, since the device wouldn't actually switch profiles if it starts on the "correct" one.
Description of Change
The Matter Switch driver currently skips dynamic profiling for every device that is assigned the generic light-color-level or light-level-colorTemperature profile. The skip exists to protect devices certified on profiles with embedded Kelvin ranges, which would lose those ranges if re-profiled. As written it is far too broad. It also blocks new and unlisted color lights from being profiled correctly.
Summary of Completed Tests
Unit tests updated, and a new unit test has been added to show the deprecated profile table override in action. Tested on-device to show backwards compatibility (device that does not use the override table).