Repository navigation
Conversation
This was done as a part of the review for the LAN integration test framework which is not yet released. A few things that would be helpful that each driver agent hand rolled: - Helper for the step from create to added: Takes create metadata and returns the mock device after building it, and registering it with the framework. It would optionally queue added/init events - Log wrapping to catch "Failed to invoke capability command handler" is needed by every test not just hue, so it should be a part of the framework with an ability to opt out - First class time control: Add test.let_time_pass(seconds), and something like test.advance_to_next_timer(). That way a test can say "the reply comes 4 s after the search" without polling os.time() with max_turns = 500. Also clarify how wait_until's time jumps interact with cosock.socket.sleep and with driver:call_with_delay/call_on_schedule (the old mock_timer_channel). These are just suggestions for things that would allow for easier writing of tests that will need to be done for all lan drivers
|
Invitation URL: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done as a part of the review for the LAN integration test framework which is not yet released.
A few things that would be helpful that each driver agent hand rolled:
These are just suggestions for things that would allow for easier writing of tests that will need to be done for all lan drivers