-
-
Notifications
You must be signed in to change notification settings - Fork 23
Make sure youtube's new url path parameter (?si) is excluded #202
Copy link
Copy link
Open
Labels
app:apiAnything related to the /apps/api backend apiAnything related to the /apps/api backend apienhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershacktoberfesthelp wantedExtra attention is neededExtra attention is needed
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
app:apiAnything related to the /apps/api backend apiAnything related to the /apps/api backend apienhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershacktoberfesthelp wantedExtra attention is neededExtra attention is needed
Projects
- StatusShow more project fieldsNo status
Youtube has a new url path parameter (
?si) for tracking. This needs to be excluded when getting a thumbnail from the video id... so the regex needs to be updated. More info here: https://gist.github.com/rodrigoborgesdeoliveira/987683cfbfcc8d800192da1e73adc486?permalink_comment_id=4672606#gistcomment-4672606Also, can we shorten the regex to this?
(youtu.*be.*)\/(watch\?v=|embed\/|v|shorts|)(.*?((?=[&#?])|$)). Needs to be tested