feat(cmd): add --light-node-limit CLI and config option

Backport of ethersphere#5559 onto the v2.8.1 tag, unchanged.

v2.8.1 already carries LightNodeLimit in libp2p.Options and already honours
it, so this adds only the CLI flag and the node.Options passthrough that
were missing. The flag defaults to 100, which is defaultLightNodeLimit, so
a node started without it behaves exactly as stock v2.8.1 does.

Carried here because swarm-stream-loadlab measures the light-node
connection ceiling against ethersphere#5556, and that needs the limit
configurable on the version we actually run.

Author: LevilkTheReal

cmd/bee/cmd/cmd.go

@@ -58,6 +58,7 @@ const (
 	optionNameChequebookVerification       = "chequebook-verification"
 	optionNameChequebookMinBalance         = "chequebook-min-balance"
 	optionNameFullNode                     = "full-node"
+	optionNameLightNodeLimit               = "light-node-limit"
 	optionNamePostageContractAddress       = "postage-stamp-address"
 	optionNamePostageContractStartBlock    = "postage-stamp-start-block"
 	optionNamePriceOracleAddress           = "price-oracle-address"
@@ -309,6 +310,7 @@ func (c *command) setAllFlags(cmd *cobra.Command) {
 	cmd.Flags().Bool(optionNameChequebookVerification, false, "reject full-node hive/handshake records that carry no chequebook address")
 	cmd.Flags().String(optionNameChequebookMinBalance, "110000000000000000", "minimum chequebook token balance required for verification, in token small units (default 11 BZZ)")
 	cmd.Flags().Bool(optionNameFullNode, false, "cause the node to start in full mode")
+	cmd.Flags().Int(optionNameLightNodeLimit, 100, "light node limit")
 	cmd.Flags().String(optionNamePostageContractAddress, "", "postage stamp contract address")
 	cmd.Flags().Uint64(optionNamePostageContractStartBlock, 0, "postage stamp contract start block number")
 	cmd.Flags().String(optionNamePriceOracleAddress, "", "price oracle contract address")

cmd/bee/cmd/start.go

@@ -329,6 +329,7 @@ func buildBeeNode(ctx context.Context, c *command, cmd *cobra.Command, logger lo
 		AutoTLSDomain:                 c.config.GetString(optionAutoTLSDomain),
 		AutoTLSRegistrationEndpoint:   c.config.GetString(optionAutoTLSRegistrationEndpoint),
 		FullNodeMode:                  fullNode,
+		LightNodeLimit:                c.config.GetInt(optionNameLightNodeLimit),
 		Logger:                        logger,
 		MinimumGasTipCap:              c.config.GetUint64(optionNameMinimumGasTipCap),
 		GasLimitFallback:              c.config.GetUint64(optionNameGasLimitFallback),

packaging/bee.yaml

@@ -145,3 +145,5 @@ password-file: "/var/lib/bee/password"
 # autotls-ca-endpoint: ""
 ## SIMD BMT hashing opt-in flag (only available on linux amd64)
 # use-simd-hashing: false
+## limit of possible connected light nodes (default: 100)
+# light-node-limit: 100

packaging/homebrew-amd64/bee.yaml

@@ -145,3 +145,5 @@ password-file: "/usr/local/var/lib/swarm-bee/password"
 # autotls-ca-endpoint: ""
 ## SIMD BMT hashing opt-in flag (only available on linux amd64)
 # use-simd-hashing: false
+## limit of possible connected light nodes (default: 100)
+# light-node-limit: 100

packaging/homebrew-arm64/bee.yaml

@@ -145,3 +145,5 @@ password-file: "/opt/homebrew/var/lib/swarm-bee/password"
 # autotls-ca-endpoint: ""
 ## SIMD BMT hashing opt-in flag (only available on linux amd64)
 # use-simd-hashing: false
+## limit of possible connected light nodes (default: 100)
+# light-node-limit: 100

packaging/scoop/bee.yaml

@@ -145,3 +145,5 @@ password-file: "./password"
 # autotls-ca-endpoint: ""
 ## SIMD BMT hashing opt-in flag (only available on linux amd64)
 # use-simd-hashing: false
+## limit of possible connected light nodes (default: 100)
+# light-node-limit: 100

pkg/node/node.go

@@ -164,6 +164,7 @@ type Options struct {
 	AutoTLSDomain                 string
 	AutoTLSRegistrationEndpoint   string
 	FullNodeMode                  bool
+	LightNodeLimit                int
 	GasLimitFallback              uint64
 	Logger                        log.Logger
 	MinimumGasTipCap              uint64
@@ -707,6 +708,7 @@ func NewBee(
 		AutoTLSCAEndpoint:           o.AutoTLSCAEndpoint,
 		WelcomeMessage:              o.WelcomeMessage,
 		FullNode:                    o.FullNodeMode,
+		LightNodeLimit:              o.LightNodeLimit,
 		Nonce:                       nonce,
 		AllowPrivateCIDRs:           o.AllowPrivateCIDRs,
 		Registry:                    registry,