Repository navigation
add open in tab to resource menu - #915
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues blocking approval of the new resource-menu action.
No open issues 🎉
What changed in this PR
Adds an Open in New Tab action to the resource menu, allowing users to open the current resource directly.
Changes:
- Shows the action and its icon when a resource URI is available.
- Opens the full URI in a new tab with
noopener,noreferrer. - Adds a test verifying the action preserves URI fragments and uses the expected window options.
| File | Description |
|---|---|
src/components/resource-actions-menu/ResourceActionsMenu.ts |
Adds the menu action, icon, and new-tab handler. |
src/components/resource-actions-menu/ResourceActionsMenu.test.ts |
Tests opening the resource URI, including its fragment. |
Review effort: Balanced
…istry@5.0.2-2) (latest: rdflib@2.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an Open in New Tab menu item