Skip to content

Commit 3fe5877

Browse files
committed
SONARJAVA-7236 Compare type arguments instead of erased type names
1 parent c40636f commit 3fe5877

1 file changed

Lines changed: 17 additions & 1 deletion

File tree

‎benchmark/src/AstSemanticDump.java‎

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,23 @@ private static String typeName(@Nullable Type type, boolean erase) {
344344
return "unknown";
345345
}
346346
String name = type.fullyQualifiedName();
347-
return erase ? erase(name) : name;
347+
return erase ? erase(name) : withArguments(type, 0);
348+
}
349+
350+
private static String withArguments(Type type, int depth) {
351+
if (type.isUnknown()) {
352+
return "unknown";
353+
}
354+
String name = erase(type.fullyQualifiedName());
355+
if (depth > 3 || !type.isParameterized()) {
356+
return name;
357+
}
358+
StringBuilder out = new StringBuilder(name).append('<');
359+
List<Type> arguments = type.typeArguments();
360+
for (int i = 0; i < arguments.size(); i++) {
361+
out.append(i == 0 ? "" : ",").append(withArguments(arguments.get(i), depth + 1));
362+
}
363+
return out.append('>').toString();
348364
}
349365

350366
private static String erase(String name) {

0 commit comments

Comments
 (0)