Skip to content

RC-789 Fix comment diff #6421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BartLucien wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

RC-789 Fix comment diff #6421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d8756
Make submodule checkout recursive
BartLucien Oct 28, 2026
f1f19f0
Add artificial difference
BartLucien Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ruling-diff-comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0
submodules: true
submodules: recursive

- name: Install uv
uses: astral-sh/setup-uv@07a047e608db84b3d8c06cd9a7c7dcc9c355c18e # v10.3.2
Expand Down
1 change: 0 additions & 1 deletion its/ruling/src/test/resources/expected/eclipse-jetty/java-S100.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"eclipse-jetty:jetty-util/src/main/java/org/eclipse/jetty/util/security/UnixCrypt.java": [
340,
349,
395,
415,
470
]
Expand Down
3 changes: 1 addition & 2 deletions its/ruling/src/test/resources/expected/eclipse-jetty/java-S107.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"eclipse-jetty:jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookie.java": [
105,
110
105

@gitar-bot gitar-bot Bot Oct 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Bug: Test-only edits to ruling baselines will break ruling ITs if merged

Commit f1f19f0 ("Add artificial difference") deletes expected issues from the eclipse-jetty ruling baselines: HttpCookie.java line 110 is removed from java-S107.json and UnixCrypt.java line 395 is removed from java-S100.json. No analyzer change in this PR stops those issues from being raised, so the ruling IT will report them as unexpected and fail. The edits only exist to trigger the ruling-diff-comment workflow. Revert the commit before the PR leaves draft so that only the submodules: recursive workflow change gets merged.

Restore the original S107 baseline entry. Also restore line 395 in java-S100.json, for example with git revert f1f19f0.:

"eclipse-jetty:jetty-http/src/main/java/org/eclipse/jetty/http/HttpCookie.java": [
105,
110
],
  • Apply fix

Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎

],
"eclipse-jetty:jetty-server/src/main/java/org/eclipse/jetty/server/session/SessionData.java": [
178
Expand Down
Loading