[david-schroeter]

---

Summary by Gitar

• Bug fix:
  • Extended DoubleCheckedLockingCheck to unwrap parentheses and logical complements in if conditions, so !(helper != null) is detected
• Tests:
  • Added regression samples for negated, double-negated, and triple-negated outer and inner null checks
  • Added compliant cases for volatile fields and already-synchronized methods, plus a non-compiling sample

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARJAVA-7282

[rombirli]

/pvf

[rombirli]

LGTM

[hashicorp-vault-sonar-prod]

📊 Performance Validation complete
🆕 0 new · 🗑️ 0 lost issues
View dashboard

Projects with unexpected PVF results:

• crate

[gitar-bot]

Code Review ✅ Approved

🟡 Medium risk · Extending the double-checked-locking rule to unwrap negations could add diagnostics for previously missed patterns, changing analysis results in affected projects.

Extends DoubleCheckedLockingCheck to unwrap parentheses and logical complements in if conditions, so negated outer null checks like !(helper != null) are now detected for S2168. Regression samples cover negated, double-negated, and triple-negated checks, plus compliant cases for volatile fields and synchronized methods. No issues found.

Verification Rules 1/1 met Repos 4 inspected · PRs 1 inspected

Functional validation No results

Rules 1 passed 2 not applicable

✅ Repository license compliance

Broader impact Repos 4 inspected PRs 1 inspected

Cross-repo 4 repositories inspected 0 open impacts

SonarSource/sonar-java-symbolic-execution Inspected
SonarSource/sonarlint-intellij Inspected
SonarSource/sonarqube Inspected
SonarSource/sonarlint-vscode Inspected

Cross-PR 1 PR inspected 0 open impacts

PR 6456: SONARJAVA-7288 Replace Eclipse JDT core with PSI in the Java frontend Inspected

Auto-approval Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube