[lijun-chen-sonarsource]

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

---

Summary by Gitar

• Behavior change:
  • Exempted unused local variables whose names start with $_ from UnusedLocalVariableCheck
• Tests:
  • Added cases for $_ variables in foreach, list, static, closure captures, and object assignments in UnusedLocalVariableCheck.php

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARPHP-1972

[asya-vorobeva]

Let's add sample cases that you mention in JIRA ticket to clarify actual usage. Provided sample doesn't illustrate purpose of change.

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[gitar-bot]

Code Review ✅ Approved

🟡 Medium risk · Exempting all local variables prefixed $_ from the unused-variable check could let genuinely unused locals escape detection.

Exempts local variables whose names start with $_ from UnusedLocalVariableCheck, covering foreach, list, static, closure capture, and object assignment cases with added test coverage. No issues found.

Verification Rules 1/1 met Repos 3 inspected · PRs 2 inspected

Functional validation No results

Rules 1 passed 2 not applicable

✅ Repository license compliance

Broader impact Repos 3 inspected PRs 2 inspected

Cross-repo 3 repositories inspected 0 open impacts

SonarSource/sonarlint-vscode Inspected
SonarSource/sonarlint-language-server Inspected
SonarSource/sonarlint-core Inspected

Cross-PR 2 PRs inspected 0 open impacts

PR #1854: SONARPHP-1593 Track reads through sibling and nested closure references Inspected
PR #1855: SONARPHP-1969 Account for dynamically accessed local variables Inspected

Auto-approval Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[karim-ouerghemmi-sonarsource]

@lijun-chen-sonarsource I let you guys merge the automatically created metadata update PR #1859 (review) once this is on master. I was about to merge, but Gitar made me aware that the underscore prefix exception is not yet on master.

[lijun-chen-sonarsource]

@karim-ouerghemmi-sonarsource Opss. Merged the rspec to hastily. Thanks for the heads up. I'll merge #1859 once this PR is merged (which should happen today).