refactor(iban): derive iban length and end indices from patterns

Remove redundant data from IbanRegistry's enum constants:

- IBAN length is now computed from the BBAN pattern instead of an
  explicit withIbanLength(...) call.
- withBankCode/withBranchCode/withAccountNumber/withNationalCheckDigit
  now take (pattern, beginIndex); the end index is derived from the
  pattern's segment length.
- StructureData stores its four positional components in an internal
  ComponentType -> Component map instead of eight parallel fields;
  public getters keep their existing signatures.
- IbanPatternConverter.Segment's static list helpers (calculateTotalLength,
  allMatch, isAllNumeric) moved onto IbanPatternConverter itself; Segment
  stays a pure value object.
- Updated call sites in IbanBuilder and the related tests accordingly.

Author: spannm

iban-commons/src/main/java/de/speedbanking/iban/AbstractNcdCountryValidator.java

@@ -110,7 +110,7 @@ public final boolean validateNationalCheckDigit(final char[] iban) {
     public final char[] calculateNationalCheckDigit(final char[] iban) {
         return ncdCalculator == null
             || !IbanConfig.isCalculateNcd()
-            ? getCountryData().getNationalCheckDigitIndexRange().applyTo(iban)
+            ? getCountryData().getNationalCheckDigitComponent().extractFrom(iban)
             : ncdCalculator.calculateNationalCheckDigit(iban);
     }
 

iban-commons/src/main/java/de/speedbanking/iban/CountryValidators.java

@@ -925,12 +925,11 @@ public boolean validateIban(final char[] iban) {
         }
     }
 
-    /** NCD-aware Validator for Togo (TG), IBAN length: 28, BBAN pattern: {@code 5!c5!n12!n2!n} */
-    static final class TG extends AbstractNcdCountryValidator {
+    /** Validator for Togo (TG), IBAN length: 28, BBAN pattern: {@code 5!c5!n12!n2!n} */
+    static final class TG extends AbstractCountryValidator {
         @Override
         public boolean validateIban(final char[] iban) {
-            return isAllDigits(iban, 9, 28)
-                && validateNationalCheckDigit(iban);
+            return isAllDigits(iban, 9, 28);
         }
     }
 

iban-commons/src/main/java/de/speedbanking/iban/Iban.java

@@ -19,7 +19,6 @@
 
 import de.speedbanking.util.Country;
 import de.speedbanking.util.Currency;
-import de.speedbanking.util.IndexRange;
 
 import java.io.IOException;
 import java.io.InvalidObjectException;
@@ -409,8 +408,8 @@ public String getBban() {
      * @since 1.8.0
      */
     public String getBankCode() {
-        if (bankCode == null && countryData.getBankCodeIndexRange() != null) {
-            bankCode = countryData.getBankCodeIndexRange().applyTo(ibanStr);
+        if (bankCode == null) {
+            bankCode = countryData.getBankCodeComponent().extractFrom(ibanStr);
         }
         return bankCode;
     }
@@ -423,8 +422,11 @@ public String getBankCode() {
      * @since 1.8.0
      */
     public String getBranchCode() {
-        if (branchCode == null && countryData.getBranchCodeIndexRange() != null) {
-            branchCode = countryData.getBranchCodeIndexRange().applyTo(ibanStr);
+        if (branchCode == null) {
+            IbanComponent component = countryData.getBranchCodeComponent();
+            if (component != null) {
+                branchCode = component.extractFrom(ibanStr);
+            }
         }
         return branchCode;
     }
@@ -456,7 +458,7 @@ public String getBankAndBranchCode() {
      */
     public String getAccountNumber() {
         if (accountNumber == null) {
-            accountNumber = countryData.getAccountNumberIndexRange().applyTo(ibanStr);
+            accountNumber = countryData.getAccountNumberComponent().extractFrom(ibanStr);
         }
         return accountNumber;
     }
@@ -469,8 +471,11 @@ public String getAccountNumber() {
      * @since 1.8.1
      */
     public String getNationalCheckDigit() {
-        if (nationalCheckDigit == null && countryData.hasNationalCheckDigit()) {
-            nationalCheckDigit = countryData.getNationalCheckDigitIndexRange().applyTo(ibanStr);
+        if (nationalCheckDigit == null) {
+            IbanComponent component = countryData.getNationalCheckDigitComponent();
+            if (component != null) {
+                nationalCheckDigit = component.extractFrom(ibanStr);
+            }
         }
         return nationalCheckDigit;
     }
@@ -538,10 +543,10 @@ public String toFormattedString() {
      * @since 1.8.5
      */
     public String toComponentString() {
-        IndexRange bankRange = countryData.getBankCodeIndexRange();
-        IndexRange branchRange = countryData.getBranchCodeIndexRange();
-        IndexRange accountRange = countryData.getAccountNumberIndexRange();
-        IndexRange ncdRange = countryData.getNationalCheckDigitIndexRange();
+        IbanComponent bankCompo = countryData.getBankCodeComponent();
+        IbanComponent branchCompo = countryData.getBranchCodeComponent();
+        IbanComponent accountCompo = countryData.getAccountNumberComponent();
+        IbanComponent ncdCompo = countryData.getNationalCheckDigitComponent();
 
         // fixed-size stack array (max 12 entries)
         int[] idx = new int[12];
@@ -550,20 +555,20 @@ public String toComponentString() {
         idx[count++] = IbanRegistry.INDEX_CHECK_DIGIT1;
         idx[count++] = IbanRegistry.INDEX_BBAN;
 
-        idx[count++] = bankRange.getBegin();
-        idx[count++] = bankRange.getEnd();
+        idx[count++] = bankCompo.getBeginIndex();
+        idx[count++] = bankCompo.getEndIndex();
 
-        if (branchRange != null) {
-            idx[count++] = branchRange.getBegin();
-            idx[count++] = branchRange.getEnd();
+        if (branchCompo != null) {
+            idx[count++] = branchCompo.getBeginIndex();
+            idx[count++] = branchCompo.getEndIndex();
         }
 
-        idx[count++] = accountRange.getBegin();
-        idx[count++] = accountRange.getEnd();
+        idx[count++] = accountCompo.getBeginIndex();
+        idx[count++] = accountCompo.getEndIndex();
 
-        if (ncdRange != null) {
-            idx[count++] = ncdRange.getBegin();
-            idx[count++] = ncdRange.getEnd();
+        if (ncdCompo != null) {
+            idx[count++] = ncdCompo.getBeginIndex();
+            idx[count++] = ncdCompo.getEndIndex();
         }
 
         // insertion sort - optimal for small fixed arrays, avoids Arrays.sort overhead