Skip to content

fix(services): align bound service operations with OpenAPI REST contracts - #445

Merged
robbecker-wf merged 1 commit into
10xfrom
10x-service-contracts-conformance
Sep 17, 2026
Merged

robbecker-wf merged 1 commit into
10xfrom
10x-service-contracts-conformance

Conversation

@robbecker-wf

@robbecker-wf robbecker-wf commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Stacked PR: Part 3 of 7

Stack Overview:

  1. #443 10x-openapi-spec-baseline -> 10x
  2. #444 10x-security-and-transport -> 10x-openapi-spec-baseline
  3. #445 10x-service-contracts-conformance (this PR) -> 10x-security-and-transport
  4. #446 10x-schema-models-and-strict-analysis -> 10x-service-contracts-conformance
  5. #447 10x-test-pyramid-and-smoke -> 10x-schema-models-and-strict-analysis
  6. #448 10x-ci-and-spec-sync -> 10x-test-pyramid-and-smoke
  7. #449 10x-conformance-plan -> 10x-ci-and-spec-sync

Summary

Repairs bound service operations against the OpenAPI specification contract definitions.

  • Activity: Fixed notification thread endpoint path (/notifications/threads/{id}) and updated star / unstar return types and status codes (204 No Content).
  • Gists: Fixed HTTP methods (PATCH for edit, PUT for star) and set explicit status code 201 for comments.
  • Git: Handled refs/ prefix correctly on createReference, editReference, and deleteReference; used query parameters for getTree recursive mode.
  • Issues: Used PUT for issue locking, renamed assignee parameter, and corrected replaceLabelsForIssue return type to List<IssueLabel>.
  • Organizations: Updated editTeam to use PATCH and added editTeamInOrg.
  • Repositories: Added createDispatchEvent, listTopics, and replaceTopics; ensured status 201 for release assets.
  • Search: Replaced custom rate-limit exceptions with standardized transport error decoding.
  • Contract Tests: Added comprehensive conformance tests in test/contract/service_contracts_test.dart.

…acts

Co-authored-by: Cursor <cursoragent@cursor.com>
@robbecker-wf
robbecker-wf force-pushed the 10x-service-contracts-conformance branch from fd3c3cd to 69a3c0d Compare September 17, 2026 00:29
@robbecker-wf
robbecker-wf merged commit 45b1f84 into 10x Sep 17, 2026
@robbecker-wf
robbecker-wf deleted the 10x-service-contracts-conformance branch September 17, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant