Skip to content

Commit fa9db9a

Browse files
committed
fix: address Copilot review comments (round 4)
- All 6 enforcement workflows: fix enforcement_mode description from "advisory (requires exception record)" to "advisory (warn-only)" — advisory is simply warn-only; no exceptions file is required - All 3 caller templates + all REUSABLE-WORKFLOWS.md examples: migrate pnpm enforcement from deprecated "mode: production/development" to "enforcement_mode: required" — eliminates deprecation warnings and legacy bridge reliance - node-enforcement.yml header: correct NODE-TEST-001 description from "Jest test suite" to "Vitest test suite (Jest fallback)" to match impl - css-enforcement.yml header: correct CSS-A11Y-001 description from "no outline:none without replacement" to "no outline:none or outline:0" to match actual grep-based check Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011dYHNxqWRU9xs97SCLvRPV
1 parent d95053b commit fa9db9a

10 files changed

Lines changed: 15 additions & 15 deletions

.github/workflows/css-enforcement.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# - CSS-SPEC-001: no ID selectors
1111
# - CSS-TOKEN-001: no hardcoded hex colors outside token definitions
1212
# - CSS-TYPE-001: no px font sizes
13-
# - CSS-A11Y-001: no outline:none without replacement
13+
# - CSS-A11Y-001: no outline:none or outline:0
1414
# - CSS-BUILD-001: production build
1515
# - CSS-BUNDLE-001: gzipped CSS bundle size limit
1616
#
@@ -40,7 +40,7 @@ on:
4040
type: string
4141
default: v1
4242
enforcement_mode:
43-
description: 'required (fail-closed) | advisory (requires exception record) | (empty = legacy mode fallback)'
43+
description: 'required (fail-closed) | advisory (warn-only) | (empty = legacy mode fallback)'
4444
required: false
4545
type: string
4646
default: ''

.github/workflows/media-enforcement.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ on:
3939
type: string
4040
default: v1
4141
enforcement_mode:
42-
description: 'required (fail-closed) | advisory (requires exception record) | (empty = legacy mode fallback)'
42+
description: 'required (fail-closed) | advisory (warn-only) | (empty = legacy mode fallback)'
4343
required: false
4444
type: string
4545
default: ''

.github/workflows/node-enforcement.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# - NODE-ENV-001: no process.env outside config module
1414
# - NODE-LOG-001: no console.* in production source
1515
# - NODE-ESM-001: package.json "type": "module"
16-
# - NODE-TEST-001: Jest test suite (if configured)
16+
# - NODE-TEST-001: Vitest test suite (Jest fallback, if configured)
1717
# - NODE-AUDIT-001: pnpm vulnerability audit
1818
#
1919
# VERIFIED VIA PRESENCE VALIDATION (warn-only pending §4 fixtures):
@@ -48,7 +48,7 @@ on:
4848
type: string
4949
default: v1
5050
enforcement_mode:
51-
description: 'required (fail-closed) | advisory (requires exception record) | (empty = legacy mode fallback)'
51+
description: 'required (fail-closed) | advisory (warn-only) | (empty = legacy mode fallback)'
5252
required: false
5353
type: string
5454
default: ''

.github/workflows/php-enforcement.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ on:
4444
type: string
4545
default: v1
4646
enforcement_mode:
47-
description: 'required (fail-closed) | advisory (requires exception record) | (empty = legacy mode fallback)'
47+
description: 'required (fail-closed) | advisory (warn-only) | (empty = legacy mode fallback)'
4848
required: false
4949
type: string
5050
default: ''

.github/workflows/pnpm-enforcement.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ on:
2121
workflow_call:
2222
inputs:
2323
enforcement_mode:
24-
description: 'required (fail-closed) | advisory (requires exception record) | (empty = legacy mode fallback)'
24+
description: 'required (fail-closed) | advisory (warn-only) | (empty = legacy mode fallback)'
2525
required: false
2626
type: string
2727
default: ''

.github/workflows/react-enforcement.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ on:
4545
type: string
4646
default: v1
4747
enforcement_mode:
48-
description: 'required (fail-closed) | advisory (requires exception record) | (empty = legacy mode fallback)'
48+
description: 'required (fail-closed) | advisory (warn-only) | (empty = legacy mode fallback)'
4949
required: false
5050
type: string
5151
default: ''

REUSABLE-WORKFLOWS.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
pnpm:
3030
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/pnpm-enforcement.yml@v1
3131
with:
32-
mode: development
32+
enforcement_mode: required
3333

3434
# Additional domain workflows (PHP, JS, CSS, formatting, etc.) will be added
3535
# to this repository over time. Add their jobs here once they exist under
@@ -64,7 +64,7 @@ jobs:
6464
pnpm:
6565
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/pnpm-enforcement.yml@v1
6666
with:
67-
mode: development
67+
enforcement_mode: required
6868
php:
6969
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/php-enforcement.yml@v1
7070
with:
@@ -86,7 +86,7 @@ jobs:
8686
pnpm:
8787
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/pnpm-enforcement.yml@v1
8888
with:
89-
mode: development
89+
enforcement_mode: required
9090
react:
9191
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/react-enforcement.yml@v1
9292
with:
@@ -118,7 +118,7 @@ jobs:
118118
pnpm:
119119
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/pnpm-enforcement.yml@v1
120120
with:
121-
mode: development
121+
enforcement_mode: required
122122
node:
123123
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/node-enforcement.yml@v1
124124
with:

caller-templates/standards-node.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
pnpm:
1515
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/pnpm-enforcement.yml@v1
1616
with:
17-
mode: production
17+
enforcement_mode: required
1818

1919
node:
2020
needs: pnpm

caller-templates/standards-php-wordpress.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
if: ${{ hashFiles('package.json') != '' }}
2020
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/pnpm-enforcement.yml@v1
2121
with:
22-
mode: production
22+
enforcement_mode: required
2323

2424
php:
2525
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/php-enforcement.yml@v1

caller-templates/standards-react.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
pnpm:
1515
uses: Starisian-Technologies/starisian-coding-standards/.github/workflows/pnpm-enforcement.yml@v1
1616
with:
17-
mode: production
17+
enforcement_mode: required
1818

1919
react:
2020
needs: pnpm

0 commit comments

Comments
 (0)