Merge pull request #3316 from Strategy11/prepare_for_6.35

Prepare for 6.35

Author: Crabcyborg

.github/workflows/push-asset-readme-update.yml

@@ -18,7 +18,3 @@ jobs:
         SVN_PASSWORD: ${{ secrets.SVN_PASSWORD }}
         SVN_USERNAME: ${{ secrets.SVN_USERNAME }}
         SLUG: formidable
-        # GitHub main is ahead of SVN trunk between releases. Without this, the
-        # action rsyncs the whole plugin, sees unreleased code / missing dist
-        # files, and bails with "Other files have been modified".
-        IGNORE_OTHER_FILES: true

changelog.txt

@@ -1,4 +1,32 @@
 == Changelog ==
+= 6.35 =
+* Security: More strict sanitizing is now applied to entry key values before it gets used in the HTML of a form.
+* Security: The value that records who last saved an entry is now always set from the current user, not allowing for any custom values unless importing.
+* New: The shortcodes list now offers show options for more types, and long names are truncated so the list stays readable.
+* New: The Processor column on the Payments list page can now be sorted.
+* New: A message is now shown on the Payments list page after bulk deleting.
+* New: The required email input used for Stripe Link payments will now display a required asterisk like other required inputs.
+* New: A new frm_builder_after_field_label hook has been added for adding content after a label in the builder.
+* New: A new frm_payment_user_id filter has been added for setting which user a payment belongs to.
+* Performance: The builder now loads much faster when there are a lot of fields. Fields loaded with AJAX are now loaded in asynchronous batches.
+* Performance: The way the denylist is checked has been optimized, so spam checks are much faster when a large amount of text is submitted.
+* Performance: Pricing updates for Stripe payments are now debounced, and are skipped on pages with no payment intents.
+* Fix: A subscription would not get cancelled after it reached its Recurring Payment Limit.
+* Fix: Payment status actions could run twice for the same Stripe Link payment.
+* Fix: Multiple customer objects would get created for Stripe Link recurring payments.
+* Fix: Subscription plan details would not update after changing the trial period.
+* Fix: A Stripe Link redirect would use the URL from Form settings instead of the URL in the confirmation action that ran.
+* Fix: Square payments would not correctly follow conditional logic when two Square actions were used.
+* Fix: The wrong amount would get used when verifying a buyer with Square.
+* Fix: Connecting and disconnecting Square would go by whichever mode was active instead of the mode that was selected.
+* Fix: In Pro, the dropdown on a style card would not populate, leaving no way to delete a style or set one as the default.
+* Fix: In Pro, a section added after a partially sized field would move into the previous row after a reload.
+* Fix: Adding the frm_first layout class would not start a new row for a group.
+* Fix: A field id used in a description would not get switched when a form was duplicated or imported.
+* Fix: Creating a field with a missing or invalid options value would raise a PHP warning and store null.
+* Fix: The Embeds column would only update when a post was inserted, so it went stale when a page was updated or deleted.
+* The old hard coded widths for the frm_grid_2 through frm_grid_10 classes have been removed from the generated stylesheets, helping to reduce the file size of styles used on the front end.
+
 = 6.34 =
 * Security: Additional validation has been added to guarantee that submitted HTML in form data by untrusted users cannot be used for XSS.
 * New: Address fields are now included in Lite!

classes/controllers/FrmFieldsController.php

@@ -67,7 +67,7 @@ public static function load_field() {
 	/**
 	 * Get a form's fields, as the form builder sees them, indexed by field id.
 	 *
-	 * @since x.x
+	 * @since 6.35
 	 *
 	 * @param int $form_id
 	 *

classes/controllers/FrmFormsController.php

@@ -1855,7 +1855,7 @@ private static function advanced_helpers( $atts ) {
 	 * Adds a shortcode for each part of a multi-part field to the field shortcode list,
 	 * so a single part can be used on its own, like [25 show=first] for a Name field.
 	 *
-	 * @since x.x
+	 * @since 6.35
 	 *
 	 * @param array $atts Includes 'field'.
 	 *
@@ -1885,7 +1885,7 @@ public static function field_part_shortcodes( $atts ) {
 	/**
 	 * Gets the parts of a multi-part field that can be shown on their own with a show= shortcode option.
 	 *
-	 * @since x.x
+	 * @since 6.35
 	 *
 	 * @param stdClass $field
 	 *
@@ -1903,7 +1903,7 @@ private static function get_field_parts( $field ) {
 		/**
 		 * Allows add-ons to add the parts of their own multi-part fields.
 		 *
-		 * @since x.x
+		 * @since 6.35
 		 *
 		 * @param array    $parts Part labels keyed by the show= option value.
 		 * @param stdClass $field The field the parts belong to.
@@ -1915,7 +1915,7 @@ private static function get_field_parts( $field ) {
 	 * Gets the parts of a Name field that are in use. Only the parts included in the
 	 * selected name layout hold a value, so the rest would always show as blank.
 	 *
-	 * @since x.x
+	 * @since 6.35
 	 *
 	 * @param stdClass $field
 	 *
@@ -1950,7 +1950,7 @@ private static function get_name_field_parts( $field ) {
 	 * Gets the parts of an Address field that are in use. The address type decides which
 	 * parts are on the form, so the rest would always show as blank.
 	 *
-	 * @since x.x
+	 * @since 6.35
 	 *
 	 * @param stdClass $field
 	 *

classes/controllers/FrmSettingsController.php

@@ -8,7 +8,7 @@ class FrmSettingsController {
 	/**
 	 * Icon for the API section, used whether the add-on is active or only a placeholder.
 	 *
-	 * @since x.x
+	 * @since 6.35
 	 *
 	 * @var string
 	 */
@@ -221,7 +221,7 @@ private static function get_settings_tabs() {
 	 * an active plugin is left alone, so nothing stands in for a section that is
 	 * really there.
 	 *
-	 * @since x.x
+	 * @since 6.35
 	 *
 	 * @param array<array> $sections Sections registered for the Global Settings page so far.
 	 *
@@ -244,7 +244,7 @@ private static function add_inactive_addon_sections( &$sections ) {
 	 * Assigning a new key lands the section at the end of the array, so the array
 	 * is rebuilt to put it where it belongs.
 	 *
-	 * @since x.x
+	 * @since 6.35
 	 *
 	 * @param array<array> $sections Sections registered for the Global Settings page so far.
 	 * @param string       $after    Key of the section the new one follows. The new section goes last when this key is not there.
@@ -281,7 +281,7 @@ private static function insert_section_after( &$sections, $after, $key, $section
 	 * the user to upgrade to it, on a gradient button that sets the upgrade
 	 * apart from a one click install.
 	 *
-	 * @since x.x
+	 * @since 6.35
 	 *
 	 * @return array
 	 */

classes/controllers/FrmUsageController.php

@@ -61,14 +61,14 @@ public static function schedule_send() {
 	 * this run before the text domain loaded.
 	 *
 	 * @since 3.06.04
-	 * @deprecated x.x
+	 * @deprecated 6.35
 	 *
 	 * @param array $schedules Unused. The registered cron schedules, keyed by schedule name.
 	 *
 	 * @return array
 	 */
 	public static function add_schedules( $schedules = array() ) {
-		_deprecated_function( __METHOD__, 'x.x' );
+		_deprecated_function( __METHOD__, '6.35' );
 		return $schedules;
 	}
 

classes/helpers/FrmAppHelper.php

@@ -29,7 +29,7 @@ class FrmAppHelper {
 	 *
 	 * @var string
 	 */
-	public static $plug_version = '6.34';
+	public static $plug_version = '6.35';
 
 	/**
 	 * @var bool