Merge pull request #2960 from Strategy11/docs/address-feedback-windsurf-rules

Address feedback and refactor Windsurf rules for Formidable patterns

Author: Crabcyborg

.eslintignore

@@ -17,6 +17,7 @@
 .php-cs-fixer.cache export-ignore
 .wp-env.json export-ignore
 .coderabbit.yaml export-ignore
+.windsurf export-ignore
 cypress.config.js export-ignore
 /bin/ export-ignore
 changelog.txt export-ignore
@@ -45,6 +46,7 @@ mago.toml export-ignore
 /resources/ export-ignore
 webpack.dev.js export-ignore
 .browserslistrc export-ignore
+/eslint-rules/ export-ignore
 /phpcs-sniffs/ export-ignore
 .deepsource.toml export-ignore
 .semgrepignore export-ignore

.eslintrc.json

@@ -19,7 +19,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v5
         with:
-          node-version: "20.10.0"
+          node-version: "22"
 
       - name: Cache dependencies
         id: cache-npm
@@ -34,7 +34,7 @@ jobs:
 
       - name: Install dependencies
         if: steps.cache-npm.outputs.cache-hit != 'true'
-        run: npm ci --include=dev
+        run: npm ci --include=dev --legacy-peer-deps
 
       - name: Run ESLint
         run: ./node_modules/.bin/eslint .

.gitattributes

@@ -0,0 +1,40 @@
+name: Stylelint
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    types: [opened, labeled, synchronize]
+
+jobs:
+  runStylelintInspection:
+    if: contains(github.event.pull_request.labels.*.name, 'run analysis')
+    name: Run Stylelint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v5
+        with:
+          node-version: "22"
+
+      - name: Cache dependencies
+        id: cache-npm
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.npm
+            node_modules
+          key: ${{ runner.os }}-node-modules-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-modules-
+
+      - name: Install dependencies
+        if: steps.cache-npm.outputs.cache-hit != 'true'
+        run: npm ci --include=dev --legacy-peer-deps
+
+      - name: Run Stylelint
+        run: npx stylelint "**/*.{css,scss}"

.github/workflows/jscs.yml

@@ -1,5 +1,16 @@
 {
 	"extends": "@wordpress/stylelint-config/scss",
+	"ignoreFiles": [
+		"**/vendor/**",
+		"**/node_modules/**",
+		"**/web-components/**",
+		"**/frm_admin.css",
+		"**/frm-settings-components.css",
+		"**/font_icons.css",
+		"**/frm_testing_mode.css",
+		"**/welcome-tour.css",
+		"**/css/formidableforms.css"
+	],
 	"rules": {
 		"no-descending-specificity": null,
 		"selector-class-pattern": null,
@@ -13,6 +24,12 @@
 				"camelCaseSvgKeywords": true,
 				"ignoreFunctions": ["currentColor"]
 			}
-		]
+		],
+		"color-named": null,
+		"declaration-property-unit-allowed-list": null,
+		"no-invalid-position-at-import-rule": null,
+		"font-family-no-missing-generic-family-keyword": null,
+		"scss/at-import-no-partial-leading-underscore": null,
+		"scss/load-no-partial-leading-underscore": null
 	}
 }

.github/workflows/stylelint.yml

@@ -16,6 +16,7 @@ Critical principles for enterprise-level plugin development.
 3. **Backward compatibility**: Maintain 100% compatibility with existing callers
 4. **No custom solutions**: Never invent new patterns. Use existing ones or search the web to review best practices, then follow the official WordPress standards or VIP guidelines.
 5. **User changes are final**: If user makes manual changes, treat as authoritative
+6. **Multi-issue fixes**: When fixing multiple issues in one request, run all 6 phases independently for each issue. Findings from one issue's phases may inform the next, but every phase is mandatory for every issue, even when issues share a root cause.
 
 ---
 
@@ -40,6 +41,7 @@ Before proposing solutions:
 - Trace execution flow from entry point to failure
 - **Analyze complete context** of the class or file being changed — all features, logic, and flows
 - **Trace parent hierarchy**: search parent classes and files up to plugin root
+- **CSS-Specific Rules - Trace complete style cascade**: When debugging CSS on an element, identify ALL classes on the element and its ancestors, then search for ALL CSS rules affecting it (not just the obvious class). Understand the complete cascade before proposing changes
 - Identify ALL affected locations in the codebase
 - Map dependencies: what calls this code, what does this code call
 - Check plugin requirements: must code work standalone or require Pro/addons
@@ -78,6 +80,8 @@ Before proposing solutions:
 - Never refactor unrelated code in the same commit
 - If a rule conflicts with existing code in the file being modified, follow the rule for new code but do not refactor unrelated existing code
 - Make the smallest change that completely solves the problem
+- **CSS-Specific Rules - Never modify shared CSS classes**: If a CSS class is already used elsewhere in the plugin, do not change its behavior. Instead, add a new specific class for the feature and define new styles for it
+- Use Big-O to compare algorithms and choose the most efficient one for large inputs and iterations
 - Never change method signatures, return types, or data structures
 - Add defensive checks where data comes in, not where used everywhere
 - Add PHPDoc/JSDoc for new methods/properties/functions and comments for complex logic