Updates to prevent deepsource noise and fix a psalm error

[Crabcyborg]

Summary by CodeRabbit

• Bug Fixes

  • Prevented errors when processing invalid or non-text icon class values.

• Tests

  • Improved test reliability and code analysis by clarifying test factory typing.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 90504ac2-543d-4203-a00f-3b141b701e84

📥 Commits

Reviewing files that changed from the base of the PR and between 378134e and 09b2df5.

📒 Files selected for processing (3)

• classes/helpers/FrmAppHelper.php
• tests/phpunit/base/FrmAjaxUnitTest.php
• tests/phpunit/base/FrmUnitTest.php

---

📝 Walkthrough

Walkthrough

The change prevents icon_by_class() from iterating over a failed preg_split() result. It also documents the concrete factory type in PHPUnit base classes for static analysis.

Changes

Icon input handling

Layer / File(s)	Summary
Guard icon class parsing classes/helpers/FrmAppHelper.php	icon_by_class() stores the preg_split() result, handles a false result, and iterates over the guarded array.

Test factory typing

Layer / File(s)	Summary
Document test factory types tests/phpunit/base/FrmUnitTest.php, tests/phpunit/base/FrmAjaxUnitTest.php	The base PHPUnit classes document $factory as FrmUnitTestFactory for static analysis.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch updates_to_prevent_deepsource_noise_and_fix_a_psalm_error

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[deepsource-io]

DeepSource Code Review

We reviewed changes in 378134e...09b2df5 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade

Security   Reliability   Complexity   Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Sep 11, 2026 2:30p.m.	Review ↗
JavaScript		Sep 11, 2026 2:30p.m.	Review ↗

---

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.