From 09b2df5c432e445947bd0c5b054f03499e012f9e Mon Sep 17 00:00:00 2001
From: Mike Letellier <mike@crabcyb.org>
Date: Fri, 11 Sep 2026 11:29:52 -0300
Subject: [PATCH] Updates to prevent deepsource noise and fix a psalm error

---
 classes/helpers/FrmAppHelper.php       | 9 ++++++++-
 tests/phpunit/base/FrmAjaxUnitTest.php | 8 ++++++++
 tests/phpunit/base/FrmUnitTest.php     | 8 ++++++++
 3 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/classes/helpers/FrmAppHelper.php b/classes/helpers/FrmAppHelper.php
index bc5297bc65..2af770008c 100644
--- a/classes/helpers/FrmAppHelper.php
+++ b/classes/helpers/FrmAppHelper.php
@@ -1378,7 +1378,14 @@ public static function icon_by_class( $class, $atts = array() ) {
 		$icon_classes = array();
 		$is_font_icon = true;
 
-		foreach ( preg_split( '/\s+/', $class, -1, PREG_SPLIT_NO_EMPTY ) as $single_class ) {
+		$single_classes = preg_split( '/\s+/', $class, -1, PREG_SPLIT_NO_EMPTY );
+
+		if ( ! $single_classes ) {
+			// preg_split returns false if $class is not a string.
+			$single_classes = array();
+		}
+
+		foreach ( $single_classes as $single_class ) {
 			if ( 'frmfont' === $single_class || 'frm_icon_font' === $single_class ) {
 				$is_font_icon = false;
 				continue;
diff --git a/tests/phpunit/base/FrmAjaxUnitTest.php b/tests/phpunit/base/FrmAjaxUnitTest.php
index d1bd54ccc8..a450facf28 100644
--- a/tests/phpunit/base/FrmAjaxUnitTest.php
+++ b/tests/phpunit/base/FrmAjaxUnitTest.php
@@ -10,6 +10,14 @@ class FrmAjaxUnitTest extends WP_Ajax_UnitTestCase {
 	protected $is_pro_active    = false;
 	protected $contact_form_key = 'contact-with-email';
 
+	/**
+	 * Narrows the inherited property to the Formidable factory so static analysis
+	 * can resolve $this->factory->form, ->field and ->entry.
+	 *
+	 * @var FrmUnitTestFactory
+	 */
+	protected $factory;
+
 	public static function wpSetUpBeforeClass( $factory ) {
 		$_POST = array();
 		FrmHooksController::trigger_load_hook( 'load_ajax_hooks' );
diff --git a/tests/phpunit/base/FrmUnitTest.php b/tests/phpunit/base/FrmUnitTest.php
index 1dfca49f05..1dad220136 100644
--- a/tests/phpunit/base/FrmUnitTest.php
+++ b/tests/phpunit/base/FrmUnitTest.php
@@ -22,6 +22,14 @@ class FrmUnitTest extends WP_UnitTestCase {
 
 	protected $is_pro_active = false;
 
+	/**
+	 * Narrows the inherited property to the Formidable factory so static analysis
+	 * can resolve $this->factory->form, ->field and ->entry.
+	 *
+	 * @var FrmUnitTestFactory
+	 */
+	protected $factory;
+
 	/**
 	 * @var FrmUnitTest
 	 */