Skip to content

Fix license status displayed when connecting - #3324

Merged
Crabcyborg merged 1 commit into
masterfrom
fix_license_status_displayed_when_connecting
Sep 11, 2026
Merged

Fix license status displayed when connecting#3324
Crabcyborg merged 1 commit into
masterfrom
fix_license_status_displayed_when_connecting

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Requires https://github.com/Strategy11/formidable-pro/pull/6621

Summary by CodeRabbit

  • New Features
    • License authorization now displays the activated license type in the admin area.
    • Upgrade prompts are automatically removed when an Elite license is activated.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 91a3b292-aa4c-449c-9584-913c2a2a6a8a

📥 Commits

Reviewing files that changed from the base of the PR and between 3a4e635 and c4837fb.

📒 Files selected for processing (3)
  • classes/models/FrmAddon.php
  • js/formidable_admin.js
  • js/src/admin/admin.js

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The activation response now passes through an overridable data hook. After successful authorization, the admin UI displays the license type and removes upgrade calls to action for Elite licenses.

Changes

License activation

Layer / File(s) Summary
Activation response hook
classes/models/FrmAddon.php
activate_license passes valid responses through the protected add_activation_response_data hook before returning them.
License type display
js/src/admin/admin.js
Successful authorization refreshes .frm_license_type_info elements. Elite licenses remove .frm_license_upgrade_cta elements.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: truongwp

Merge Risk: ⚪ Minimal · up to c4837

The activation response and license display changes are ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: correcting the displayed license status during connection. It is concise and specific.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_license_status_displayed_when_connecting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Sep 11, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 3a4e635...c4837fb on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Sep 11, 2026 6:48p.m. Review ↗
JavaScript Sep 11, 2026 6:48p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@Crabcyborg
Crabcyborg merged commit 6749ab9 into master Sep 11, 2026
25 of 37 checks passed
@Crabcyborg
Crabcyborg deleted the fix_license_status_displayed_when_connecting branch September 11, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant