Focus the tab together with opening the panel

This removes the flicker. It may make the tab switching feel less snappy
because we are deliberately waiting a bit but both the tab and the hold
version feel much better this way.

Author: FichteFoll

plugin/commands.py

@@ -4,13 +4,7 @@
 from .ctrl_release import is_available
 from .history import current_group_selection_state, sync_selection_history
 from .mru import collect_entries
-from .session import (
-    cancel_session,
-    preview_entry,
-    reopen_panel_at_index,
-    schedule_panel,
-    show_panel,
-)
+from .session import cancel_session, reopen_panel_at_index, schedule_panel, show_panel
 from .state import get_state
 
 
@@ -33,7 +27,6 @@ def run(self, *, forward=True, selected_index: int = 1) -> None:
             state.session_pending_token += 1
             state.session_active = True
             state.session_selected_index = selected_index
-            preview_entry(window, state)
             show_panel(window, state)
             return
 
@@ -49,7 +42,6 @@ def run(self, *, forward=True, selected_index: int = 1) -> None:
         state.session_group = active_group
         state.session_entries = entries
         state.session_selected_index = selected_index
-        preview_entry(window, state)
         schedule_panel(window, state, token=state.session_pending_token)
 
 

plugin/session.py

@@ -16,7 +16,7 @@ def on_release() -> None:
         if state.session_active:
             _commit_session(window, state)
         elif state.session_pending:
-            state.clear_session()
+            _commit_pending_session(window, state)
 
     state.ctrl_release_poller = CtrlReleasePoller(on_release, 25)
     state.ctrl_release_poller.start()
@@ -77,6 +77,18 @@ def preview_entry(window, state: TabStackWindowState) -> None:
     apply_group_selection(window, entry.selection, state.session_group)
 
 
+def _commit_pending_session(window, state) -> None:
+    entries = state.session_entries
+    if not entries:
+        state.clear_session()
+        return
+
+    index = clamp_index(state.session_selected_index, len(entries))
+    selection = entries[index].selection
+    apply_group_selection(window, selection, state.session_group)
+    state.clear_session()
+
+
 def _commit_session(window, state) -> None:
     if not state.session_active:
         return