Skip to content

Commit 0ddfe99

Browse files
committed
Clear the two reliability findings behind the C rating
SonarQube Cloud rated reliability C for two bugs. PatternInEquals compared new Money(999, "EUR") with an identical expression (S1764); main() now keeps the first Money in a variable, with the same output. The other finding (S2259, NullPointerException) is the point of SwitchWithoutCaseNull, so the pom ignores it for that file, with the reason next to the rule - as in java-bufferedreader.
1 parent cfbeb24 commit 0ddfe99

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

‎pom.xml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,14 @@
2727
them. -->
2828
<sonar.coverage.exclusions>**/*.java</sonar.coverage.exclusions>
2929

30-
<sonar.issue.ignore.multicriteria>e1</sonar.issue.ignore.multicriteria>
30+
<sonar.issue.ignore.multicriteria>e1,e2</sonar.issue.ignore.multicriteria>
3131
<!-- The examples print their results; IO.println() is the program's output, not logging. -->
3232
<sonar.issue.ignore.multicriteria.e1.ruleKey>java:S106</sonar.issue.ignore.multicriteria.e1.ruleKey>
3333
<sonar.issue.ignore.multicriteria.e1.resourceKey>**/*.java</sonar.issue.ignore.multicriteria.e1.resourceKey>
34+
<!-- SwitchWithoutCaseNull passes null to a switch without case null on purpose: the
35+
NullPointerException it ends with is what the article shows. -->
36+
<sonar.issue.ignore.multicriteria.e2.ruleKey>javabugs:S2259</sonar.issue.ignore.multicriteria.e2.ruleKey>
37+
<sonar.issue.ignore.multicriteria.e2.resourceKey>**/SwitchWithoutCaseNull.java</sonar.issue.ignore.multicriteria.e2.resourceKey>
3438
</properties>
3539

3640
<build>

‎src/main/java/PatternInEquals.java‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ public int hashCode() {
2121
}
2222

2323
void main() {
24-
IO.println(new Money(999, "EUR").equals(new Money(999, "EUR")));
25-
IO.println(new Money(999, "EUR").equals(new Money(999, "USD")));
26-
IO.println(new Money(999, "EUR").equals("9.99 EUR"));
24+
Money price = new Money(999, "EUR");
25+
IO.println(price.equals(new Money(999, "EUR")));
26+
IO.println(price.equals(new Money(999, "USD")));
27+
IO.println(price.equals("9.99 EUR"));
2728
}

0 commit comments

Comments
 (0)