feat: label session and job pods with the preemptible flag

Author: wesjdj

components/renku_data_services/notebooks/core_sessions.py

@@ -1222,6 +1222,8 @@ async def start_session(
     if user.is_anonymous:
         labels["renku.io/anonymous-session"] = "true"
 
+    labels["renku.io/preemptible"] = str(resource_class.preemptible).lower()
+
     if session_type.is_non_interactive:
         session_extras = session_extras.extra_container_as_sidecars()
 
@@ -1442,6 +1444,8 @@ async def patch_session(
         labels["renku.io/anonymous-session"] = "true"
     if not labels.get("renku.io/session-type"):
         labels["renku.io/session-type"] = SessionType.interactive.value
+    if rc is not None:
+        labels["renku.io/preemptible"] = str(rc.preemptible).lower()
     if not patch.metadata:
         patch.metadata = AmaltheaSessionV1Alpha1MetadataPatch()
     patch.metadata.labels = labels
@@ -1454,6 +1458,8 @@ async def patch_session(
         labels["renku.io/anonymous-session"] = "true"
     if not labels.get("renku.io/session-type"):
         labels["renku.io/session-type"] = SessionType.interactive.value
+    if rc is not None:
+        labels["renku.io/preemptible"] = str(rc.preemptible).lower()
     if not isinstance(patch.spec.template, TemplatePatch):
         patch.spec.template = TemplatePatch(metadata=TemplateMetadataPatch())
     if not isinstance(patch.spec.template.metadata, TemplateMetadataPatch):

test/bases/renku_data_services/data_api/test_sessions.py

@@ -1818,6 +1818,50 @@ async def test_starting_session(
             assert session_res.json["error"]["message"] == expected_error_message
 
 
+@pytest.mark.asyncio
+@pytest.mark.xdist_group("sessions")  # Needs to run on the same worker as the rest of the sessions tests
+@pytest.mark.parametrize("preemptible", [True, False])
+async def test_starting_session_labels_preemptible_pods(
+    app_manager: DependencyManager,
+    sanic_client: SanicASGITestClient,
+    create_project,
+    create_resource_pool,
+    create_session_launcher,
+    amalthea_installation,
+    user_headers,
+    regular_user_api_user,
+    valid_resource_pool_payload,
+    preemptible: bool,
+) -> None:
+    project = await create_project(sanic_client, "Some project", visibility="public")
+    classes = [dict(rc, preemptible=preemptible) for rc in valid_resource_pool_payload["classes"]]
+    resource_pool = await create_resource_pool(admin=True, classes=classes)
+    launcher = await create_session_launcher(
+        "launcher",
+        project["id"],
+        resource_class_id=resource_pool["classes"][0]["id"],
+        environment={
+            "container_image": "renku/renkulab-py:3.10-0.23.0-amalthea-sessions-3",
+            "environment_kind": "CUSTOM",
+            "name": "test",
+            "port": 8888,
+            "environment_image_source": "image",
+        },
+    )
+
+    _, res = await sanic_client.post(
+        "/api/data/sessions",
+        headers=user_headers,
+        json={"project_id": project["id"], "launcher_id": launcher["id"]},
+        cookies={"_renku_session": "some content"},
+    )
+    assert res.status_code == 201, res.text
+
+    session = await app_manager.config.nb_config.k8s_v2_client.get_session(res.json["name"], regular_user_api_user.id)
+    assert session is not None
+    assert session.metadata.labels["renku.io/preemptible"] == str(preemptible).lower()
+
+
 @pytest.mark.asyncio
 @pytest.mark.xdist_group("sessions")  # Needs to run on the same worker as the rest of the sessions tests
 @pytest.mark.parametrize(